Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The "on_top" parameter of EditorSpatialGizmoPlugin.create_material has no effect #44077

Closed
Zylann opened this issue Dec 3, 2020 · 1 comment · Fixed by #90183
Closed

The "on_top" parameter of EditorSpatialGizmoPlugin.create_material has no effect #44077

Zylann opened this issue Dec 3, 2020 · 1 comment · Fixed by #90183

Comments

@Zylann
Copy link
Contributor

Zylann commented Dec 3, 2020

Godot 3.2.3
Windows 10 64 bits
OpenGL ES 3.0 Renderer: GeForce GTX 1060 6GB/PCIe/SSE2

I'm making a plugin where I show a custom wireframe gizmo with EditorSpatialGizmoPlugin. I need it to be shown on top, so I set the on_top parameter to true in create_material. However it does not have any effect.

image

With wireframe mode turned on, you can see where the gizmo is supposed to be:
image

MRP:
GizmoOnTop.zip
Check the plugin is enabled in ProjectSettings, open main.tscn, select the MeshInstance.

@Zylann Zylann changed the title The "on_top" property of EditorSpatialGizmoPlugin.create_material has no effect The "on_top" parameter of EditorSpatialGizmoPlugin.create_material has no effect Dec 3, 2020
@stevenjt
Copy link
Contributor

stevenjt commented Apr 3, 2024

I hit this same bug when working on a custom gizmo. I've linked a PR with a fix that worked for me.

Since the MRP was for Godot 3.x I updated it to 4.3 (it still opens in 4.2.1 stable which I've used to compare it with my custom build):
GizmoOnTop_4_3.zip

With the linked PR the circle renders over the geometry when the gizmo is being used as expected:

GizmoOnTop

@akien-mga akien-mga added this to the 4.3 milestone Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants