Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected pixel jitter when using 2d stretch mode and keep stretch aspect #46681

Open
Skullfurious opened this issue Mar 5, 2021 · 3 comments

Comments

@Skullfurious
Copy link

Skullfurious commented Mar 5, 2021

Godot version:
3.2.3.stable.official

OS/device including version:
Windows 10 20H2, GTX 1080ti, R7 3800X

Issue description:
The bottom and right side of the Godot application jitter when being resized if you enable 2D Stretch mode with Aspect locking.

This only occurs on the bottom and right side. Left and top work as expected without jitter.

Steps to reproduce:
Under DIsplay -> Window:
Size
Width: 1280
Height: 720
Stretch
Mode: 2d
Aspect: keep
(This enables letterboxing like Celeste on ultrawide monitors)

Under Rendering -> Quality:
2d
Use Pixel Snap

Drag Window around and look at bottom / right side letter boxing.

Minimal reproduction project:
Demo.zip

i0BlRliFsh.1.mp4
WF3EdRtMQb.1.mp4
@Skullfurious
Copy link
Author

@Calinou Calinou changed the title Unexpected pixel jitter when using Stretch mode with a locked aspect ratio. Unexpected pixel jitter when using 2d stretch mode the keep stretch aspect Mar 5, 2021
@Calinou
Copy link
Member

Calinou commented Mar 5, 2021

@Skullfurious window.cpp only exists in the master branch, not 3.2.

Also, if you want to avoid any kind of pixel jitter, you need to enforce integer scaling using a script: godotengine/godot-proposals#1666

@Skullfurious
Copy link
Author

The jitter doesnt come from the actual canvas resolution changing. Not demonstrated in the videos is the top and left sides not jittering. None of the pixels within the bounds of the viewport jitter.

The only jitter is when the letterboxing is shifting on the bottom and right side of the window.

ZfNhQrdRXA.1.mp4

@Calinou Calinou changed the title Unexpected pixel jitter when using 2d stretch mode the keep stretch aspect Unexpected pixel jitter when using 2d stretch mode and keep stretch aspect Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants