-
-
Notifications
You must be signed in to change notification settings - Fork 21.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Using NodePath with certain default values shows an error in editor #54468
Comments
I reproduced this error on linux x64 when editor try to suggest autocomplete options. |
It doesn't break, but substantially affects the overall performance of the editor, as in large project I'm working on right now it's flooding the output with this kind of errors. Thanks for the repro steps! |
Can you check again? I just tried and I can reproduce the bug, but for me it happens the same in 3.4 RC 2, 3.3.4-stable, 3.3-stable and even 3.2-stable. So it doesn't appear to be a regression. |
MRP doesn't trigger |
I've bisected what causes my problem and it's this PR #49491 that triggers "Node not found" errors. It's most probably related to |
CC @pycbouh |
Sorry, I don't understand what problem is being reported. Like @akien-mga, I can reproduce the problem described in the OP with the attached MPR in both 3.4 RC2 and 3.3 stable. @Listwon What exactly did you track down to be caused by the aforementioned PR? Can you provide a test project and the steps that only trigger the "Node not found" error in 3.4, but not in 3.3? Because the MRP attached by @AnidemDex triggers the error in either version (and indeed is the expected behavior, I think, like you yourself mention). |
The MRP was actually not reproduce the bug that @AnidemDex and @Listwon both seem to experience. The MRP covers only a normal error that happens from misusing the API in a script, while the "bug" here seems to be a misuse of the API in the editor code itself, hence the But indeed we need a way to reproduce the bug to solve it. |
Oh I couldn't reproduce this error with the MRP, I only get the script error when running the project, nothing in the editor itself (even when setting them as |
I just followed instructions that said to use the reference somehow 🙃 So I've added |
@pycbouh I'm trying to find it right now and prepare the MRP. What I found so far is that one of the scripts loaded by
and I get Node not found errors. If I try to open one of those scenes, I'm flooded with cascade of similar errors |
Can reproduce on 3.3, wich is... weird. Someone on discord said that wasn't able to reproduce it on 3.3.4. I guess I have to replicate that by myself before opening this issue. So, have I to close this issue? Modify its title? Sorry for the problems in advance |
@AnidemDex I think what you've highlighted is an existing problem, but a problem nonetheless. If the problem you describe is the same as I noticed and it's related to the auto-completion, we can adjust the title/descripting in the OP and keep it open. Unless this is a duplicate. However, @Listwon's report seems to be about something new. That probably deserves a new issue report so that we can properly track it and hopefully fix for the next 3.4 RC. |
I'm still struggling to prepare the good MRP. It is of course related to |
The results are cached after the first run, so it shouldn't contribute to the slow down when it's the same base types. See #51211 |
@AnidemDex Errors with auto-complete are caused by user code. It fails trying to get the reference to the object, because it tries to execute |
Godot version
3.4 RC2
System information
Windows 11 x64
Issue description
If you try to use an exported
NodePath
variable with a default value of""
,NodePath("")
orNodePath()
the editor will throw an error when trying to use a node that uses that variable:Is something very similar to when you try to use a node in a
tool
script.This error doesn't breaks the editor or the game.
but this was working on 3.3Steps to reproduce
Minimal reproduction project
Thanks to eons on discord helping me to replicate this issue:
project.zip
The text was updated successfully, but these errors were encountered: