Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Print an error when exporting to iOS with icons that don't match their required size #55229

Closed
Tekuzo opened this issue Nov 22, 2021 · 4 comments · Fixed by #56861
Closed

Print an error when exporting to iOS with icons that don't match their required size #55229

Tekuzo opened this issue Nov 22, 2021 · 4 comments · Fixed by #56861

Comments

@Tekuzo
Copy link

Tekuzo commented Nov 22, 2021

Godot version

3.4 Stable

System information

M1 Macbook Air

Issue description

When trying to export an iOS project, the export will fail if the Spotlight Icons are provided in the Optional Icons section of the export options.
An error message will state that the export failed due to a configuration error in the preset.

Exporting works normally if the spotlight icons are removed from the export.
The export still works with the 180 X 180, 152 X 152, 167 X 167 optional icons.

Steps to reproduce

Export an iOS project and provide the spotlight icons.

Minimal reproduction project

Project 3.zip

@Calinou
Copy link
Member

Calinou commented Nov 22, 2021

cc @bruvzg

@bruvzg bruvzg self-assigned this Nov 22, 2021
@Tekuzo
Copy link
Author

Tekuzo commented Nov 22, 2021

Sorry, this seems to have been user error. I am going to close it. One of my images was too big for the spot I was trying to put it in.

@Tekuzo Tekuzo closed this as completed Nov 22, 2021
@Calinou
Copy link
Member

Calinou commented Nov 22, 2021

Reopening, as this is something we should detect and print a proper error message about when exporting.

@Calinou Calinou reopened this Nov 22, 2021
@Calinou Calinou added enhancement and removed bug labels Nov 22, 2021
@Calinou Calinou changed the title iOS Export Fails When Optional Spotlight Icons are Selected Print an error when exporting to iOS with icons that don't match their required size Nov 22, 2021
@bruvzg
Copy link
Member

bruvzg commented Nov 22, 2021

as this is something we should detect and print a proper error message about when exporting.

It is printing Invalid icon size .... error in the log, but we should do something with the error popup, which only displays a message based on the returned error code (and it's almost always ERR_UNCONFIGURED).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants