Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: GPUParticles2D interpolation not implemented yet (unlike in GPUParticles3D) #55357

Closed
Calinou opened this issue Nov 26, 2021 · 3 comments · Fixed by #58685
Closed

Vulkan: GPUParticles2D interpolation not implemented yet (unlike in GPUParticles3D) #55357

Calinou opened this issue Nov 26, 2021 · 3 comments · Fixed by #58685

Comments

@Calinou
Copy link
Member

Calinou commented Nov 26, 2021

Related to #51318.

Godot version

4.0.dev (5efe80f)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 470.74)

Issue description

GPUParticles2D doesn't have an Interpolate property available. This helps make particles feel smoother without using too much GPU time, especially when attractors and collision are enabled. The effect is more noticeable on high refresh rate monitors, but now that GPUParticles simulation occurs at 30 Hz by default, interpolation is needed on 60 Hz monitors too to ensure smooth visuals.

Steps to reproduce

  • Add a GPUParticles2D node.
  • Notice how there's no Interpolate property in the inspector.

Minimal reproduction project

N/A

@IgorKordiukiewicz
Copy link
Contributor

Is it only missing the interpolation property or also the implementation for the property in 2D?

@Calinou
Copy link
Member Author

Calinou commented Mar 1, 2022

Is it only missing the interpolation property or also the implementation for the property in 2D?

I think both the implementation and the property are missing in 2D, but I'm not 100% sure.

@IgorKordiukiewicz
Copy link
Contributor

IgorKordiukiewicz commented Mar 2, 2022

So it looks like only the property was missing as after just adding it, switching it off and on changes the behavior:

gpu_particles_2d_interpolation.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants