Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vulkan: LightmapGI does not react to non-default environment Color, Energy or Sky Contribution when using the Scene environment mode #56138

Closed
Tracked by #56033
Calinou opened this issue Dec 21, 2021 · 2 comments · Fixed by #56220

Comments

@Calinou
Copy link
Member

Calinou commented Dec 21, 2021

Related to #56078 (which is the same issue but for 3.x's CPU lightmapper).

Godot version

4.0.dev (489f11e)

System information

Fedora 34, GeForce GTX 1080 (NVIDIA 470.74)

Issue description

The GPU lightmapper does not react to non-default environment Color, Energy or Sky Contribution in WorldEnvironment when the BakedLightmap is configured to use the Scene environment mode. I made sure to bake lightmaps again after changing the Environment's ambient light properties.
The GPU lightmapper does not react to custom sky rotation either: #56135

Left: real-time ambient lighting, right: baked ambient lighting

Default environment settings

2021-12-21_19 11 36

Ambient Color #000000, Sky Contribution = 0.5, Energy = 1.0

2021-12-21_19 12 22

Ambient Color #604020, Sky Contribution = 0.0, Energy = 1.0

2021-12-21_19 13 27

Steps to reproduce

  • Add a WorldEnvironment node. Configure a ProceduralSky.
  • Add a LightmapGI node. Set the environment mode to Scene.
  • Instance two identical 3D scenes imported with the Static Lightmaps option. Right-click one of them in the Scene tree dock then enable Editable Children. Select its child mesh and set Global Illumination > Mode to Disabled, so that it is not included in baking.
  • Select the BakedLightmap node and click Bake Lightmaps at the top of the 3D editor viewport.
  • Remember to bake lightmaps every time you adjust the ambient light settings!

Minimal reproduction project

test_lightmap_environment_master.zip

@tbillington
Copy link

tbillington commented Oct 17, 2023

This seems to be broken in godot 4.1 (haven't tested any other versions). Hope this is the same issue. If not do you have a suggestion of where I can report this?

LightmapGI Disabled

Screenshot 2023-10-17 at 10 17 54 am

LightmapGI Enabled and clicked Bake Lightmaps

Screenshot 2023-10-17 at 10 18 28 am

LightmapGI Settings

Screenshot 2023-10-17 at 10 19 00 am

@AThousandShips
Copy link
Member

Please open a new report as this issue was fixed so not the same issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants