Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting too big icon for custom type can break the editor #57286

Closed
KoBeWi opened this issue Jan 27, 2022 · 4 comments · Fixed by #75472
Closed

Setting too big icon for custom type can break the editor #57286

KoBeWi opened this issue Jan 27, 2022 · 4 comments · Fixed by #75472

Comments

@KoBeWi
Copy link
Member

KoBeWi commented Jan 27, 2022

Godot version

3.5 beta1 and probably master

System information

W10

Issue description

image
None of the icons adjust texture's size, so using too big texture results in this abomination.

"Fixing" this is probably unfeasible, so at least EditorPlugin.add_custom_type() description should mention a standard size for an icon.

Steps to reproduce

  1. Have EditorPlugin with add_custom_type()
  2. Use some very big texture for the icon

Minimal reproduction project

No response

@Calinou
Copy link
Member

Calinou commented Jan 27, 2022

Related to #20197.

@fire
Copy link
Member

fire commented Jan 27, 2022

Hope that this interacts with hidpi where the size might be 3x the normalized pixel size.

@KoBeWi
Copy link
Member Author

KoBeWi commented Feb 27, 2022

Ok I just discovered that, just like #20197, it doesn't happen with class_name.
image

@akien-mga
Copy link
Member

akien-mga commented Sep 16, 2022

Another example :)
image

We "just" need to enforce a max size I believe. I.e. resizing the user provided icon as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants