Moving resource renames dependents to *.depren

[nathanfranke]

Godot version

v4.0.alpha.custom_build [f4b0c7a]

System information

Arch Linux 5.15.34-1-lts

Issue description

Note that the scene and script were not open.

Steps to reproduce

1. Move the script to a different directory or move the entire directory

Minimal reproduction project

test1.zip

[Calinou]

@nathanfranke Can you reproduce this on 3.4.4?

[nathanfranke]

Cannot reproduce in 3.4.4 nor 3.5.beta4

[markdibarry]

This still seems to be happening on alpha 7.

[Calinou]

cc @timothyqiu

[timothyqiu]

@markdibarry Can you provide some instructions on how to reproduce it? The steps in OP works fine for me.

[markdibarry]

I haven't delved into a new project to make a minimal reproduction, but here's a project with a build off of cbdc33b.
In this case, MetalHockeyStick.tscn is an inherited scene from HockeyStick.tscn.

2022-04-30.10-20-34.mp4

[markdibarry]

@timothyqiu Built from a commit yesterday, and still having the issue. Created a minimal repro:
Depren_bug.zip
Just rename the Char1.tscn to anything else and it'll create a .depren file off of Char2.tscn.

[timothyqiu]

I am unable to reproduce the extra .depren file with the MRP on Arch Linux. Maybe only reproducible on Windows? (I don't have access to a Windows machine right now, so I am not sure.)

[markdibarry]

I am on a Windows machine, so that may be the case.

[nathanfranke]

I cannot reproduce on Arch (same setup as original post)

v4.0.alpha.custom_build [bc7ccc9]

Edit: Still can't reproduce even if I make player2.tscn that inherits player.tscn and move/rename all of the files.

[markdibarry]

Did a fresh build this morning on another Windows machine, and MRP still has the issue, so I guess we can confirm it's Windows (not sure about Mac) specific.

[akien-mga]

CC @godotengine/windows

[bruvzg]

Seems like ResourceLoaderText is holding multiple references to the source file, and one unref is not enough (before making FileAccess/DirAccess ref. counted, close call was leaving a bunch of invalid file access handles).

[markdibarry]

Tested and working. Thanks @bruvzg and @timothyqiu !