Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shader array uniforms dont always update in editor correctly #74680

Closed
bud11 opened this issue Mar 9, 2023 · 2 comments · Fixed by #76438 or #74937
Closed

Shader array uniforms dont always update in editor correctly #74680

bud11 opened this issue Mar 9, 2023 · 2 comments · Fixed by #76438 or #74937

Comments

@bud11
Copy link

bud11 commented Mar 9, 2023

Godot version

4.0 stable

System information

Forward+ renderer, rx470

Issue description

Creating a uniform array in shader and then changing its value in inspector will lock the variable type for some reason

Steps to reproduce

  1. Create a shader with something like uniform vec3[10] whatever;
  2. Add something to the array
  3. Change the array to something else, maybe vec4
  4. Uniform will still show as vec3 in editor

seems to happen with all datatypes though, ive currently got it stuck on int array somehow even though it is clearly a vec4
reloading shader/scene/engine or even changing the variable name doesnt fix it, annoying

Minimal reproduction project

trivial recreation

@bud11
Copy link
Author

bud11 commented Mar 10, 2023

I just looked into the scene file text and I think the issue stems from the lack of a PackedVector4Array type. PackedVector3 exists and works fine for vec3 if I edit the scene file to that but I cant make an equivalent edit for vec4

@akien-mga
Copy link
Member

Reopening as #76438 was reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants