Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Floating Editor Dock unusable in Single Window Mode #79673

Closed
Sauermann opened this issue Jul 19, 2023 · 3 comments · Fixed by #79793
Closed

Floating Editor Dock unusable in Single Window Mode #79673

Sauermann opened this issue Jul 19, 2023 · 3 comments · Fixed by #79793

Comments

@Sauermann
Copy link
Contributor

Godot version

v4.2.dev.custom_build [0c2144d]

System information

Debian Linux X11 Xfce

Issue description

Prerequisite: Be in Single Window Mode in the Editor
The Filesystem Dock is unusable when it is floating, which is not expected.
It appears garbled in the top-left corner:
image

The following errors are shown:

  editor/window_wrapper.cpp:220 - Condition "!is_window_available()" is true.
  editor/window_wrapper.cpp:202 - Condition "!get_window_enabled()" is true. Returning: Rect2i()
  editor/window_wrapper.cpp:207 - Condition "!get_window_enabled()" is true. Returning: -1
  editor/window_wrapper.cpp:207 - Condition "!get_window_enabled()" is true. Returning: -1

bisecting lead to #62378
possibly related to #44439

Steps to reproduce

  1. Start a project in the Editor
  2. Switch to Single Window Mode in the Editor and reload (if necessary)
  3. Make the Filesystem Dock floating

Minimal reproduction project

Editor issue

@YuriSizov
Copy link
Contributor

I definitely tested some things in the single window mode and floating docks recently and never noticed such an issue with the docks. I wonder if it can be platform specific.

@mieldepoche
Copy link
Contributor

happens on my ubuntu with all docks

@trollodel
Copy link
Contributor

trollodel commented Jul 22, 2023

That button shouldn't be available in single window mode (I forgot to disable it in #62378).
I'll make a PR soon to disable it.

As a side note: in #62378 I disabled the floating docks in single window mode as I thought it isn't very useful to move docks while being contained in the window. This may be considered a regression, so I'd like to see opinions about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants