Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken warning popup after creating a C# plugin #80883

Closed
duarteroso opened this issue Aug 22, 2023 · 3 comments · Fixed by #83576
Closed

Broken warning popup after creating a C# plugin #80883

duarteroso opened this issue Aug 22, 2023 · 3 comments · Fixed by #83576

Comments

@duarteroso
Copy link

duarteroso commented Aug 22, 2023

Godot version

4.2.dev.mono.custom_build.8e0346bad

System information

macOS

Issue description

After finishing the creating a plugin using the Create New Plugin flow, a warning popup appear all red making it impossible to know what the warning is about.

Steps to reproduce

  1. Go to Project Settings
  2. Under the Plugins tab, create a new plugin
  3. Fill up the detail (I created a C# script)
  4. A warnning should appear after closing the creation window

Looking at the console, this could be the warning
Another resource is loaded from path 'res://addons/my_other_plugin/OtherPlugin.cs' (possible cyclic resource inclusion).

image

Minimal reproduction project

CSPlugin.zip

@raulsntos
Copy link
Member

raulsntos commented Aug 22, 2023

You probably had the Active now? option checked. In this case, the warning should look like this:

image

This is because C# scripts needs to be built before the plugin can be activated, so the Active now? option should always be unchecked for C# plugins. This is mentioned in the Making plugins documentation page.


This seems to be a rendering issue. I can reproduce it in Linux with v4.1.stable.mono.official [9704596] and v4.0.1.stable.mono.official [cacf499] but not with 4.0. I also can't reproduce with Single Window Mode.

image

Looks like it might be a regression from #73365. cc @bruvzg

@duarteroso
Copy link
Author

duarteroso commented Aug 22, 2023

This is because C# scripts needs to be built before the plugin can be activated, so the Active now? option should always be unchecked for C# plugins. This is mentioned in the Making plugins documentation page

Would it make sense to hide it if C# is selected?
Feels like a better UX if there is no case for the option to ever be enabled when C# is selected.

@Calinou
Copy link
Member

Calinou commented Aug 23, 2023

Would it make sense to hide it if C# is selected?

Yes, I agree the checkbox should be unchecked and disabled when you set the language to C#. A warning should also be displayed below to mention that the option isn't available for C# plugins. The UI has changed in 4.2: #76778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants