Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShaderGlobalsOverride - Params changes lost on reload #82090

Closed
OhiraKyou opened this issue Sep 22, 2023 · 0 comments · Fixed by #82100
Closed

ShaderGlobalsOverride - Params changes lost on reload #82090

OhiraKyou opened this issue Sep 22, 2023 · 0 comments · Fixed by #82100

Comments

@OhiraKyou
Copy link

Godot version

v4.2.dev5.official [e3e2528]

System information

Godot v4.2.dev5 - Fedora Linux 38 (Workstation Edition) - X11 - GLES3 (Compatibility) - AMD Radeon RX 560 Series (polaris11, LLVM 16.0.6, DRM 3.52, 6.4.15-200.fc38.x86_64) () - Intel(R) Core(TM) i5-2500K CPU @ 3.30GHz (4 Threads)

Issue description

I expect the ShaderGlobalsOverride node to retain changes to its params when the scene is saved and the project is reloaded. It does not.

I initially noticed this on v4.1.1.stable.official [bd6af8e] and tested v4.2.dev5.official [e3e2528] to confirm that it was still present in the dev builds.

Steps to reproduce

  1. Open the attached project in Godot v4.2-dev5.
  2. Load scenes/test_scene.tscn.
  3. Select the ShaderGlobalsOverride node.
  4. Edit the global_test_vec3 global shader parameter in the ShaderGlobalsOverride node's inspector.
  5. Save the scene.
  6. Close the editor.
  7. Reload the editor and project.
  8. Select the ShaderGlobalsOverride node again.
  9. Observe that the modified parameter has returned to its initial value.

Minimal reproduction project

Godot 4.2-dev-5 - ShaderGlobalsOverride Test 1.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants