Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some times can't add node in visualshader editor #83805

Closed
CsloudX opened this issue Oct 23, 2023 · 6 comments · Fixed by #85205
Closed

Some times can't add node in visualshader editor #83805

CsloudX opened this issue Oct 23, 2023 · 6 comments · Fixed by #85205

Comments

@CsloudX
Copy link

CsloudX commented Oct 23, 2023

Godot version

v4.2.beta2.official [f8818f8]

System information

Windows 10, 64bit

Issue description

Some times can't add node in visualshader editor

Steps to reproduce

  1. Open a VisualShader file for edit.
  2. Click the Add Node... button, it will popup menu, it is OK.
  3. Direct close the menu.
  4. Clikd the Add Node... again, the menu can't popup.
    GIF

Minimal reproduction project

/

@Calinou
Copy link
Member

Calinou commented Oct 23, 2023

I can't reproduce this on 4.2.beta f8818f8 (Linux). I've tried both single-window mode enabled and disabled.

How are you closing the Add Node window? Are you pressing Escape or clicking outside? Clicking outside doesn't close the window for me.

@CsloudX
Copy link
Author

CsloudX commented Oct 23, 2023

Oh, I'm found it, the menu was in backgound.
GIF

@CsloudX
Copy link
Author

CsloudX commented Oct 23, 2023

How are you closing the Add Node window? Are you pressing Escape or clicking outside? Clicking outside doesn't close the window for me.

clicking outside

@LiorArbel
Copy link

Happened to me too now, pretty confusing, if you started adding a node and then didn't add one, it would make sense to either automatically close the small window when you change the window back to Godot\another program, or to bring this window back to focus if you click add node and it's already open.

@jsjtxietian
Copy link
Contributor

Oh, I'm found it, the menu was in backgound. GIF GIF

Same for me, my pr fixes the problem, you can help test :)

@akien-mga akien-mga added this to the 4.2 milestone Nov 22, 2023
@Zylann
Copy link
Contributor

Zylann commented Apr 8, 2024

The same fate seems to have occurred for my graph editor, which uses a similar popup. What happened to the "click outside to close" behavior?
I can set my dialog to exclusive too I guess, just a bit more annoying to aim for the close button.

I also noticed in some circumstances that this popup can now get stuck unresponsive after specific focus changes/clicking around, eventually blocking the whole editor as a result (so far resolving with alt/tab). I haven't found the pattern to make it happen though, but had it occur a few times.

visual_shader_popup_randomly_stuck.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants