Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve textureSize usage in process material #83894

Open
QbieShay opened this issue Oct 24, 2023 · 1 comment · May be fixed by #84074
Open

Improve textureSize usage in process material #83894

QbieShay opened this issue Oct 24, 2023 · 1 comment · May be fixed by #84074

Comments

@QbieShay
Copy link
Contributor

Godot version

4.2beta3

System information

Fedora, RX 590

Issue description

Follow up to #83831

The particle system currently uses textureSize() an unnecessary amount of times and it needs to be optimized.

Steps to reproduce

/

Minimal reproduction project

/

@QbieShay QbieShay added this to the 4.x milestone Oct 24, 2023
@QbieShay QbieShay self-assigned this Oct 24, 2023
@clayjohn
Copy link
Member

Basically we just need to read textureSize once and store it in a variable that we use later. We can read it at the same time that we initialize all the randomness params.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants