Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.2 beta 4] Pressing Enter after typing file name no longer confirms "Create Shader" dialogue #84433

Closed
Goldenlion5648 opened this issue Nov 3, 2023 · 5 comments · Fixed by #84539

Comments

@Goldenlion5648
Copy link
Contributor

Godot version

4.2 beta4

System information

Godot v4.2.beta4 - Windows 10.0.19045 - GLES3 (Compatibility) - NVIDIA GeForce GTX 1050 Ti (NVIDIA; 31.0.15.2647) - Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 Threads)

Issue description

I just pressed the "new shader dropdown"
image

and typed the name test123,, but when I pressed enter, the dialogue did not close (nothing happened). Doing this same thing in 4.1 does close the dialogue and create the file.

Steps to reproduce

Create a sprite 2d

Add a new shader material

Add new shader

type a name for the shader file and press enter

notice nothing happens

Minimal reproduction project

N/A

@Goldenlion5648 Goldenlion5648 changed the title Pressing Enter after typing file name no longer confirms "Create Shader" dialogue [4.2 beta 4] Pressing Enter after typing file name no longer confirms "Create Shader" dialogue Nov 3, 2023
@DxUr
Copy link

DxUr commented Nov 4, 2023

@Goldenlion5648 It works fine on Arch/Linux

@synalice
Copy link
Contributor

synalice commented Nov 4, 2023

I've just tested it (Windows 10) and the issue isn't present is v4.2-dev2 but does appear in v4.2-dev3. So it is somewhere between these two versions.

@DxUr, could you please maybe try running these two versions on your machine to verify this doesn't happen on Linux?

(4.2-dev2 download link)
(4.2-dev3 download link)

I'll try to bisect.

@DxUr
Copy link

DxUr commented Nov 4, 2023

I've just tested it (Windows 10) and the issue isn't present is v4.2-dev2 but does appear in v4.2-dev3. So it is somewhere between these two versions.

@DxUr, could you please maybe try running these two versions on your machine to verify this doesn't happen on Linux?

(4.2-dev2 download link) (4.2-dev3 download link)

I'll try to bisect. My hardware is not the best one out there, so any help is appreciated 🤕 I'll update this comment with info about what commits are good and bad!

Good: da81ca6 Bad: 79e28e0

No Issue

@synalice
Copy link
Contributor

synalice commented Nov 4, 2023

Updates on bisection.
Git says d275a74 is the first bad commit.

d275a7487d6728a490184971589f5e4854965466 is the first bad commit
commit d275a7487d6728a490184971589f5e4854965466
Author: detomon <[email protected]>
Date:   Fri Jul 28 13:09:02 2023 +0200

    Initialize MSDF parameters in BaseMaterial3D with default

 doc/classes/BaseMaterial3D.xml | 2 +-
 scene/resources/material.cpp   | 5 ++++-
 2 files changed, 5 insertions(+), 2 deletions(-)

@KoBeWi
Copy link
Member

KoBeWi commented Nov 5, 2023

Related: #82328
The fix will likely be similar.

Git says d275a74 is the first bad commit.

Doesn't look related.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants