AudioStream's internal get_stream_name seems to be entirely unused, rendering _get_stream_name pointless.

[Mickeon]

Tested versions

Starting from 4.0

System information

Windows 10

Issue description

Opening this issue before doing something hasty.

In the source code, it seems like AudioStream's get_stream_name is overridden properly for almost every inherited AudioStream type. However, outside of the tests, this method is not ever actually called.

This also makes the exposed, overridable method _get_stream_name entirely pointless, as the returned name is not ever used for anything.

The simplest solution to this issue is to expose get_stream_name.¹ The "bad ending" involves deprecating the method outright.

Steps to reproduce

This requires a look at the source code. Find every reference of get_stream_name. Every mention is an appropriate override of the original, but it is never called for any actual purpose.

Minimal reproduction project (MRP)

No need.

Footnotes

1. Can we, like, stop exposing methods without making sure they're actually useful for something? Please? I'm so peeved about this. "Undocumented" may as well be "not ever utilized" and by extension, engine bloat! ↩