Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audio Files referenced by AudiostreamPlayers are not deleted properly, instead are converted to wav file then formatted as text and saved in scene file #87314

Open
Proggle opened this issue Jan 17, 2024 · 2 comments

Comments

@Proggle
Copy link
Contributor

Proggle commented Jan 17, 2024

Tested versions

Tested it with v4.3.dev.gh-87058 [dab3ed5fc] as well as the latest stable.

System information

Godot v4.3.dev (dab3ed5fc) - Windows 10.0.22621 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 3080 (NVIDIA; 31.0.15.3770) - 12th Gen Intel(R) Core(TM) i9-12900 (24 Threads)

Issue description

When removing an audio file (tested Wav, Ogg, and Mp3) from the project (right clicking on the filesystem tab and selecting delete) it warns if the file is a dependency, and says that it will be removed
image

However, while that exact file is removed, the data is NOT. Instead, the data gets saved in a much less compressed format and hid in the tscn files that reference it

Steps to reproduce

Create a project with an Audiostreamplayer 2d
originalaudio.zip

image

Delete the mp3 from the file system in godot
Save the project.

Observe that main.tscn is now over 2 mb. Open it up, and see this ascii formatted byte array

image

I'd expect instead that deleting a file would either set references in nodes that include it to null, or leave them referencing an empty file and throw an error, rather than moving the data into the scene itself in a much less compressed format. If I'm deleting a mp3 from within godot I probably don't want it in my project at all, and I definitely expect it to make the filesize of my project smaller instead of bigger.

Minimal reproduction project (MRP)

wavConversion.zip

@Proggle Proggle changed the title Mp3s referenced by AudiostreamPlayers are not deleted properly, converted to wav file then formatted as text in scene Mp3s referenced by AudiostreamPlayers are not deleted properly, instead are converted to wav file then formatted as text and saved in scene file Jan 18, 2024
@Calinou
Copy link
Member

Calinou commented Jan 18, 2024

Can you reproduce this with WAV and Ogg Vorbis audio?

@Proggle
Copy link
Contributor Author

Proggle commented Jan 18, 2024

Can you reproduce this with WAV and Ogg Vorbis audio?

Yep, does it with those too, have updated title.

@Proggle Proggle changed the title Mp3s referenced by AudiostreamPlayers are not deleted properly, instead are converted to wav file then formatted as text and saved in scene file Audio Files referenced by AudiostreamPlayers are not deleted properly, instead are converted to wav file then formatted as text and saved in scene file Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants