Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Baking lightmaps always prints a warning message about PSO caching #87532

Closed
Calinou opened this issue Jan 24, 2024 · 2 comments · Fixed by #87340
Closed

Baking lightmaps always prints a warning message about PSO caching #87532

Calinou opened this issue Jan 24, 2024 · 2 comments · Fixed by #87340

Comments

@Calinou
Copy link
Member

Calinou commented Jan 24, 2024

Tested versions

4.3.dev 0bcc0e9

System information

Godot v4.3.dev (0bcc0e9) - Fedora Linux 39 (KDE Plasma) - X11 - Vulkan (Forward+) - dedicated NVIDIA GeForce RTX 4090 (nvidia; 545.29.06) - 13th Gen Intel(R) Core(TM) i9-13900K (32 Threads)

Issue description

When baking LightmapGI, I always get a warning message:

WARNING: There's already a RenderingDeviceDriverVulkan instance doing PSO caching. Only one can at the same time. This one won't.
     at: pipeline_cache_create (drivers/vulkan/rendering_device_driver_vulkan.cpp:2198)

Assuming this is a limitation we can't lift (and not a bug), I suggest silencing this particular instance when baking lightmaps since it's not relevant information for end users here. This could be done by moving it to print_verbose() or having a property to disable the warning in local RenderingDevices.

PS: The warning message could also mention which instance of the RenderingDevice it is (e.g. with an object ID), so you can distinguish it when multiple local RenderingDevices are printing it.

cc @DarioSamo @RandomShaper

Steps to reproduce

  • Bake a LightmapGI node.

Minimal reproduction project (MRP)

test_lightmap_preview_bake_4.x.zip

@DarioSamo
Copy link
Contributor

DarioSamo commented Jan 24, 2024

Can you confirm if #87340 fixes it? It'll specifically disable PSO caching for other instances that aren't the singleton of RD.

@Calinou
Copy link
Member Author

Calinou commented Jan 24, 2024

Can you confirm if #87340 fixes it?

That fixes it, thanks 🙂

@akien-mga akien-mga added this to the 4.3 milestone Feb 12, 2024
@akien-mga akien-mga added the bug label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants