Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Importing .fbx files results in circular dependency errors when trying to instantiate the file in an unsaved scene through the 3D Viewport. #91062

Closed
Tracked by #91519
ByteWiseLogic opened this issue Apr 23, 2024 · 6 comments

Comments

@ByteWiseLogic
Copy link

Tested versions

  • Reproduced in 4.3dev5.mono
  • Not reproducible in 4.2.stable
  • Not reproducible in 4.2.stable.mono

System information

Godot v4.3.dev5.mono - Windows 10.0.22631 - Vulkan (Forward+) - dedicated NVIDIA GeForce GTX 1050 (NVIDIA; 31.0.15.5212) - 12th Gen Intel(R) Core(TM) i5-12400F (12 Threads)

Issue description

I can't drag and drop .fbx files into the 3D viewport when editing in a new unsaved scene, due to Circular Dependencies. The same issue goes for new scenes that contain the .fbx file in the node tree.
I'm supposed to be able to just drag and drop the files into the 3D viewport.

Steps to reproduce

Make sure to import the provided model using the ufbx importer.

  1. Drag the provided FBX model into the 3D viewport, after which the editor will crash.
  2. If you followed step 1. Reopen the editor.
  3. Then create a new scene, add any Node3D as the root node. But do not save the scene yet.
  4. Drag any FBX into the 3D Viewport. You'll then get an error at the bottom left of the viewport, stating "Can't instantiate: Circular dependency found at SK_Chr_Alien_01.fbx"
  5. If you open MRP.tscn and drag the FBX file into the viewport, you won't run into any issues.

Conclusion: Dragging FBX files into the viewport in an unsaved scene, results in a circular dependency error. I have not tested this with other file formats.

Minimal reproduction project (MRP)

MRP.zip
MRP is not needed, however one will still be provided.

@WorldNulptr
Copy link

It happened to 4.3-dev5 too

@fire
Copy link
Member

fire commented May 1, 2024

I'm curious if this happens with a gltf file too, I suspect it might be a general issue.

@fire
Copy link
Member

fire commented May 24, 2024

Need to check if #92279 fixes this

@fire
Copy link
Member

fire commented May 24, 2024

From my testing I think #92279 fixes this.

Screen.Recording.2024-05-24.at.10.16.30.AM.mov

@fire
Copy link
Member

fire commented May 24, 2024

Testing on 4.3dev5.mono

  1. drag fbx into the empty scene crashes
  2. making a new node and dragging into the viewport doesn't crash
  3. opening the tscn and dragging into the viewport doesn't crash

@fire
Copy link
Member

fire commented May 29, 2024

Should be fixed by #92279

@fire fire closed this as completed May 29, 2024
@akien-mga akien-mga added this to the 4.3 milestone May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants