Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android template apk build errors on Windows #91195

Closed
TCROC opened this issue Apr 26, 2024 · 0 comments · Fixed by #91339
Closed

Android template apk build errors on Windows #91195

TCROC opened this issue Apr 26, 2024 · 0 comments · Fixed by #91339

Comments

@TCROC
Copy link
Contributor

TCROC commented Apr 26, 2024

Tested versions

Godot v4.3.dev.mono (463ede1f7)

System information

Windows 10

Issue description

Scons currently errors when building an apk during the template creation process. This is due to this line here:

"./gradlew",

There are 2 issues with this line.

  1. It is executing the bash script instead of the batch script
  2. It appears that Windows has some special cases with subprocess.call as can be seen in this stack overflow: https://stackoverflow.com/a/4616867/9733262
  • That particular solution suggests passing "Shell=true", but when testing that also causes its own issues due to trying to treat the . operator as a program itself.

  • This solution appears to actually fix it on my local test: https://stackoverflow.com/a/39474235/9733262

This was discovered when adding windows support to my godot-src project over here: https://github.com/Lange-Studios/godot-src.git.

I will be putting a PR in for review shortly with a fix.

Steps to reproduce

I will be putting a PR in for review shortly with a fix so don't worry about reproducing. But for sake of completion:

  1. git clone
  2. scons build android template (whatever the args are)

Minimal reproduction project (MRP)

NA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants