Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚀 v3 Request: Detailed Binding for Query, Form, Headers, Params... #1821

Closed
efectn opened this issue Mar 18, 2022 · 4 comments · Fixed by #1981
Closed

🚀 v3 Request: Detailed Binding for Query, Form, Headers, Params... #1821

efectn opened this issue Mar 18, 2022 · 4 comments · Fixed by #1981
Assignees
Milestone

Comments

@efectn
Copy link
Member

efectn commented Mar 18, 2022

Fiber already has QueryParser, BodyParser and ReqHeadersParser but they're really limited and not extendable. Also i think we don't need gorilla/schema.

I think creating binding sub-directory will solve this problem. https://github.com/gin-gonic/gin/tree/master/binding. It'll provide more more detailed binding specs. (without default validator, maybe custom validator function can be added, #1766).

Also adding all methods to ctx would be make ctx really mess and big. So we should add these binding methods by sub-method.

Bind().URI()
Bind().Form()
Bind().Params()
Bind().Headers()

Look These:

@hotrungnhan
Copy link

can we change validator function by passing another implemen?

@efectn
Copy link
Member Author

efectn commented Jul 6, 2022

can we change validator function by passing another implemen?

Yes

@hotrungnhan
Copy link

hope it release soon

@efectn
Copy link
Member Author

efectn commented Jul 13, 2022

hope it release soon

Hi. I'll start implementing this after closing some PRs for v3. https://github.com/orgs/gofiber/projects/1

@efectn efectn self-assigned this Jul 23, 2022
@efectn efectn linked a pull request Jul 26, 2022 that will close this issue
9 tasks
@efectn efectn closed this as completed Aug 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants