Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: FuzzTests are sometimes throwing away unrecognized bytes #91

Closed
awalterschulze opened this issue Aug 8, 2015 · 7 comments
Closed

Comments

@awalterschulze
Copy link
Member

dvyukov/go-fuzz#76

@awalterschulze
Copy link
Member Author

https://github.com/gogo/fuzztests
More work is required.

@awalterschulze awalterschulze changed the title Task: Create Fuzz Tests Using GoFuzz Bug: FuzzTests are sometimes throwing away unrecognized bytes Sep 14, 2015
@awalterschulze
Copy link
Member Author

@dvyukov
I fixed some fuzz tests for the generated unmarshaler
e8b9b26#diff-6bca0143efa485acde512d77ff13d42f
Like so
e8b9b26#diff-e0188cb7643b9790acd32abc395a5659
That these fuzztests found
https://github.com/gogo/fuzztests/tree/dd8509cb52dd1c848ba92335cff036fb6a6ac3d1

I did find that I could shrink the examples quite a bit to produce the same error.
If you look at TestFuzzSint64Overflow you can see the original bytes that produced the error commented out and the input bytes I used to reproduce the error which is a subset of the bytes in the original.

@dvyukov
Copy link

dvyukov commented Sep 16, 2015

@awalterschulze Thanks, filed dvyukov/go-fuzz#100

@awalterschulze
Copy link
Member Author

Fixed another fuzz test failure
2093b57
Found using this version of the fuzztests
https://github.com/gogo/fuzztests/tree/e62df375312286dd3e1e65abffef3a3407dcd6b0

@awalterschulze
Copy link
Member Author

Maybe I am missing something
golang/protobuf#77

@awalterschulze
Copy link
Member Author

golang/protobuf#76

@awalterschulze
Copy link
Member Author

I think there has been enough fuzzing for now.
Comparing the errors from golang and gogo protobuf would be the next thing to do, but I think at least the current generated code is better now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants