Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

New Theme: Lean Launch Page #290

Closed
FelicianoTech opened this issue Sep 12, 2017 · 6 comments
Closed

New Theme: Lean Launch Page #290

FelicianoTech opened this issue Sep 12, 2017 · 6 comments

Comments

@FelicianoTech
Copy link

Theme: https://github.com/felicianotech/hugo-theme-lean-launch-page

This is my first theme submission so let me know if I missed anything. Looking forward to more.

@digitalcraftsman
Copy link
Member

Hello @FelicianoTech,

thank you very much for sharing this theme with the Hugo community 👍
Let's take the last mile to get it merged:

When building your theme I get an error message that readFile tries to open an non-existing file in the index.html template. My guess is that you hard-coded directory doesn't work anymore because the name of the repository has been changed.

Last year it was reported that the default baseurl set by Hugo was registered by a spammer (gohugoio/hugo#2575). As far as I know nothing happened. To avoid such things please change your baseurl to https://www.example.com as the domain that's currently set is available for purchase.

Regards,
Digitalcraftsman

@FelicianoTech
Copy link
Author

@digitalcraftsman Fixed both issues.

Yes, I did rename the theme last minute. Great catch about baseURL, I never thought of that.

@digitalcraftsman
Copy link
Member

Since you renamed the theme please fix the $directory variable in the index.html as well. Right now the theme demo fails to build because the path still contains the old repo name.

@FelicianoTech
Copy link
Author

@digitalcraftsman I thought I did, can you link me? I don't see anything here: https://github.com/felicianotech/hugo-theme-lean-launch-page/blob/master/layouts/index.html

@digitalcraftsman
Copy link
Member

digitalcraftsman commented Sep 12, 2017

Pardon, that was my mistake. While updating your theme I didn't noticed that Git throw an error message (about refusing to merge unrelated histories as the changes are only in the initial commit).

Nonetheless, your theme builds fine and should appear soon on the theme site. Furthermore, I'll promote your theme on Hugo's official Twitter account.

@FelicianoTech
Copy link
Author

That's my fault, I rebased (since the repo is so knew). Once "it's out" I won't be rebasing on master anymore. :)

Thank you for your help, and for everything else I've seen you do around Hugo.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants