-
-
Notifications
You must be signed in to change notification settings - Fork 244
New Theme: Den #389
Comments
Hi @shaform Thanks for your theme submission! I just tested your theme and the example site is generated with the build script for the Hugo Themes site. But there is one small issue. Due to the way that the Theme Site is structured your header image is not found because you use But your example site will be published in a subdirectory, so you need to replace instances of If you can please do the above and I will mark your theme as ready to be added on the site. Thanks! |
@onedrawingperday Thanks! I have changed |
That wasn't needed, but it's also fine. However now your CSS file will not load. Like so: The forward slash makes the link relative to the root and that's why the CSS is 404, when your example site is generated. Let me know once you do this small change. Thanks! |
@onedrawingperday Done! |
Sorry to bother you again. But actually your change to Please revert this change in your header and footer partials and use The CSS and the header image load fine now. Thanks! |
@onedrawingperday Thanks! I actually was already using What I changed:
|
Since the fact that the language prefix would be added twice for links added via frontmatter is a little bit counter-intuitive, I've opened an issue for this as well: gohugoio/hugo#4995. |
@shaform Everything is looking good with the example site when I execute the build script for the Hugo Themes site. @digitalcraftsman this theme is ready to be added to the website |
@onedrawingperday I can add you to the "Hugo web group" so you could add/commit themes yourself if you ... want? |
@bep Thanks but not at this stage. I don't feel confident enough to commit new themes on my own. Maybe later, once I familiarize myself a bit more with how git submodules work and how to update them all at once. Besides @digitalcraftsman needed help for this week and the next. It's not like he will have exams forever. |
@shaform your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account. |
Theme submission
Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.
Link to my theme repository: https://github.com/shaform/hugo-theme-den
I made sure that...
README.md
describing my themeLICENSE.md
theme.toml
images/
folder with the required dimensionshttps://example.com
is set as base url inexampleSite/config.{toml, yaml, json}
to avoid the abuse of unused domainsFeel free to ask questions. We're glad to help.
Hi,
I am submitting a new theme: https://github.com/shaform/hugo-theme-den
Please let me know if there are any problems. Thanks!
The text was updated successfully, but these errors were encountered: