Skip to content
This repository has been archived by the owner on Jul 5, 2021. It is now read-only.

🙏🏻 Update theme: Hello Friend #393

Closed
8 tasks done
panr opened this issue Jul 24, 2018 · 6 comments
Closed
8 tasks done

🙏🏻 Update theme: Hello Friend #393

panr opened this issue Jul 24, 2018 · 6 comments

Comments

@panr
Copy link

panr commented Jul 24, 2018

Theme [update] submission

@digitalcraftsman @onedrawingperday Hi, again. I'm sorry for the inconvenience, but I've spotted some minor bugs in my theme after submission...

  1. Post meta-data is misaligned on Safari (macOS) 🙊
  2. Readme file has relative path to preview image, so on your showcase it's now broken... 😢
  3. Theme has issue with Browserlist settings in package.json

I've already fixed these bugs. Could you re-upload my theme? 🙏🏻

Link to my theme repository: https://github.com/panr/hugo-theme-hello-friend

I made sure that...

  • the repository contains a good README.md describing my theme
  • an open source license has been added to LICENSE.md
  • all metadata have been added to theme.toml
  • screenshots have been added in the images/ folder with the required dimensions
  • https://example.com is set as base url in exampleSite/config.{toml, yaml, json} to avoid the abuse of unused domains
  • the site's content is as neutral as possible (contains no ads etc.) and reflects the features of my theme
  • I tested my theme against the gohugoio/HugoBasicExample
    • I've checked the developer tools' console in my browser for error messages
@onedrawingperday
Copy link
Contributor

onedrawingperday commented Jul 24, 2018

@panr Sorry I missed the image in the theme's README.

However only @digitalcraftsman can update the theme in this repository. He's busy preparing for exams and he will do it once he has the time.

Thanks for your understanding!

@panr
Copy link
Author

panr commented Jul 24, 2018

@onedrawingperday ok, no problem ;-)

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Jul 24, 2018

@panr Just a minute, can you please point me to the broken image URL?
I see nothing broken in your theme's showcase.

The README opens directly on your theme's repo on GitHub. (as it's supposed to be) and I see the screenshot in it.

@panr
Copy link
Author

panr commented Jul 24, 2018

@onedrawingperday maybe it's Safari, but alt text doesn't appear...
I've fixed my README file few minutes ago by placing absolute link to the image on Github repo.

image-bug

@onedrawingperday
Copy link
Contributor

onedrawingperday commented Jul 24, 2018

Ok @panr thanks! I just noticed it. BTW @digitalcraftsman just fixed / updated your theme. 👍

@panr
Copy link
Author

panr commented Jul 24, 2018

🎉

Thank you guys! Everything looks fine now! Cheers 🍻

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants