-
-
Notifications
You must be signed in to change notification settings - Fork 244
New Theme (port): Athena #415
Comments
Yes. You need to commit the resources folder with all its contents in your theme’s repo after running Hugo server not from the published site. Thanks for your submission! |
I think this is done, please let me know if there's anything I missed. Thank you! |
Now your theme will work in the basic version of Hugo. @digitalcraftsman will look into your theme further once he can. |
@mtn could you please remove the @onedrawingperday have you been able to generate the demo with the added ressource folder? Locally, I'm using Hugo v0.48 (not the extended version as on the server). The demo button is shown but points to a blank page (or 404 page on the actual website). Edit: a demo is generated but the stylesheets are missing (see https://themes.gohugo.io/theme/athena-hugo-theme/) |
No I didn't test this theme. I only replied to the author's question regarding committing the I viewed the source of the demo and I noticed that the stylesheet has the following URL: I think that the author needs to use Also the same needs to be done for any other theme assets that are generated through Hugo Pipes. |
Yep, those are mistakes on my part. I'll make an update and ping you guys once it's fixed. |
@onedrawingperday Should I just use |
No. Only use See the commit of the updated README #421 It has some useful links. |
@onedrawingperday Thanks for directing me to that. Both changes are now on master. |
@mtn The themes were updated just now and if you look at https://themes.gohugo.io/theme/athena-hugo-theme/ you will see that there are no posts in your demo. You only have Other than that your demo looks fine. Do the above changes and let me know. Thanks. |
@onedrawingperday done |
@mtn Good. @digitalcraftsman The Athena Theme is ready to be promoted with a Tweet and this submission can be closed. |
Thanks @onedrawingperday for your review 👍 Your theme should appear soon on Hugo's theme site. Next, I'll promote your theme on Hugo's official Twitter account. |
Theme submission
Before submitting a theme please make sure you've read the README.md. It describes in detail what information are needed and which requirements have to be fulfilled for the submission. The check list below can help you.
Link to my theme repository: https://github.com/mtn/athena-hugo-theme
I made sure that...
README.md
describing my themeLICENSE.md
theme.toml
images/
folder with the required dimensionshttps://example.com
is set as base url inexampleSite/config.{toml, yaml, json}
to avoid the abuse of unused domainstoCSS
andPostCSS
that I have committed the/resources
directory with all generated assets, for my theme to work in the basic version of HugoFeel free to ask questions. We're glad to help.
I'm not totally sure what to do on the last one (generating assets). Do I need to manually copy the
resources
from the rendered site to the theme?The text was updated successfully, but these errors were encountered: