Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 module breaks vendoring #104

Closed
buckhx opened this issue Sep 18, 2018 · 3 comments
Closed

v3 module breaks vendoring #104

buckhx opened this issue Sep 18, 2018 · 3 comments
Labels
duplicate This issue or pull request already exists

Comments

@buckhx
Copy link

buckhx commented Sep 18, 2018

Describe the Bug
Adding the v3 module breaks systems relying on vendoring b/c github.com/golang-migrate/migrate/v3 is not a code path.

Seeing as how modules are still experimental in go1.11, imports using the standard vendor pattern should still be supported.

This commit changes all the import paths to v3
16dea48

@dhui dhui added the duplicate This issue or pull request already exists label Sep 18, 2018
@dhui
Copy link
Member

dhui commented Sep 18, 2018

Closing in favor of #103

@dhui dhui closed this as completed Sep 18, 2018
@dhui
Copy link
Member

dhui commented Sep 19, 2018

Actually, this may be a separate issue than #103
Sorry about the quick close.

How are you pinning your dependencies? Any release before v3.5.2 should not required an import change. Obviously, if you're using the latest and greatest (e.g. master branch), you'll need to update your imports.

Maybe reverting the change (releasing v3.5.3 and using v4 for module support) will fix this issue as Go 1.11 modules require an import path change w/ the current migrate version numbers...

@dhui dhui reopened this Sep 19, 2018
@dhui
Copy link
Member

dhui commented Oct 11, 2018

Closing due to lack of a response. This is probably a duplicate or related.

v3.5.3 (and v3.5.4 if you're using docker) no longer use Go modules. v4 has been release with Go module support.

@dhui dhui closed this as completed Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants