From 9e8a03bcc5467996a40cb87fea5f5990587ee4ee Mon Sep 17 00:00:00 2001 From: Dmitri Shuralyov Date: Thu, 8 Aug 2024 17:52:55 -0400 Subject: [PATCH] main.star: enable linux-amd64-typesalias postsubmit for Go 1.23 and tip New information in go.dev/issue/68798 shows that having this builder available for 1.23 and at tip will be helpful, at least in the short term. Also run it in postsubmit (for 1.23/tip only, where it's meant to pass), and also in presubmit as of the next CL. For golang/go#68798. Change-Id: I72183cc8703b65ecb265e01b18288651a7e64cfb Reviewed-on: https://go-review.googlesource.com/c/build/+/604335 Reviewed-by: Dmitri Shuralyov Reviewed-by: Tim King LUCI-TryBot-Result: Go LUCI Auto-Submit: Dmitri Shuralyov --- generated/commit-queue.cfg | 33 + generated/cr-buildbucket.cfg | 1522 +++++++++++++++++++++++++++++++--- generated/luci-milo.cfg | 42 + generated/luci-scheduler.cfg | 68 ++ main.star | 23 +- 5 files changed, 1554 insertions(+), 134 deletions(-) diff --git a/generated/commit-queue.cfg b/generated/commit-queue.cfg index a7250fc9e0..2619e67b9f 100644 --- a/generated/commit-queue.cfg +++ b/generated/commit-queue.cfg @@ -24587,6 +24587,10 @@ config_groups { name: "golang/security-try/go1.23-linux-amd64-staticlockranking" disable_reuse: true } + builders { + name: "golang/security-try/go1.23-linux-amd64-typesalias" + disable_reuse: true + } builders { name: "golang/security-try/go1.23-linux-amd64_c2s16-perf_vs_parent" includable_only: true @@ -25107,6 +25111,10 @@ config_groups { name: "golang/security-try/gotip-linux-amd64-staticlockranking" disable_reuse: true } + builders { + name: "golang/security-try/gotip-linux-amd64-typesalias" + disable_reuse: true + } builders { name: "golang/security-try/gotip-linux-amd64_c2s16-perf_vs_parent" includable_only: true @@ -29121,6 +29129,11 @@ config_groups { path_regexp: "src/runtime/[^/]+" } } + builders { + name: "golang/try/go1.23-linux-amd64-typesalias" + includable_only: true + disable_reuse: true + } builders { name: "golang/try/go1.23-linux-amd64_c2s16-perf_vs_parent" includable_only: true @@ -29978,6 +29991,11 @@ config_groups { path_regexp: "src/runtime/[^/]+" } } + builders { + name: "golang/try/gotip-linux-amd64-typesalias" + includable_only: true + disable_reuse: true + } builders { name: "golang/try/gotip-linux-amd64_c2s16-perf_vs_parent" includable_only: true @@ -86625,6 +86643,11 @@ config_groups { name: "golang/try/x_tools-go1.23-linux-amd64-race" disable_reuse: true } + builders { + name: "golang/try/x_tools-go1.23-linux-amd64-typesalias" + includable_only: true + disable_reuse: true + } builders { name: "golang/try/x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" includable_only: true @@ -87793,6 +87816,11 @@ config_groups { includable_only: true disable_reuse: true } + builders { + name: "golang/try/x_tools-go1.23-linux-amd64-typesalias" + includable_only: true + disable_reuse: true + } builders { name: "golang/try/x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" includable_only: true @@ -88057,6 +88085,11 @@ config_groups { name: "golang/try/x_tools-gotip-linux-amd64-race" disable_reuse: true } + builders { + name: "golang/try/x_tools-gotip-linux-amd64-typesalias" + includable_only: true + disable_reuse: true + } builders { name: "golang/try/x_tools-gotip-linux-amd64_c2s16-perf_vs_parent" includable_only: true diff --git a/generated/cr-buildbucket.cfg b/generated/cr-buildbucket.cfg index a29a85ef91..88d71804ab 100644 --- a/generated/cr-buildbucket.cfg +++ b/generated/cr-buildbucket.cfg @@ -12630,6 +12630,65 @@ buckets { enable: true } } + builders { + name: "go1.23-linux-amd64-typesalias" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "pool:luci.golang.ci" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "coord_mode": {' + ' "build_builder": "golang/ci-workers/go1.23-linux-amd64-typesalias-build_go",' + ' "builders_to_trigger_after_toolchain_build": [' + ' "golang/ci/x_tools-go1.23-linux-amd64-typesalias"' + ' ],' + ' "num_test_shards": 4,' + ' "test_builder": "golang/ci-workers/go1.23-linux-amd64-typesalias-test_only"' + ' },' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 1,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "coordinator-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "go1.23-linux-amd64_c2s16-perf_vs_release" swarming_host: "chromium-swarm.appspot.com" @@ -17767,6 +17826,65 @@ buckets { enable: true } } + builders { + name: "gotip-linux-amd64-typesalias" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "pool:luci.golang.ci" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "coord_mode": {' + ' "build_builder": "golang/ci-workers/gotip-linux-amd64-typesalias-build_go",' + ' "builders_to_trigger_after_toolchain_build": [' + ' "golang/ci/x_tools-gotip-linux-amd64-typesalias"' + ' ],' + ' "num_test_shards": 4,' + ' "test_builder": "golang/ci-workers/gotip-linux-amd64-typesalias-test_only"' + ' },' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 1,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "coordinator-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "gotip-linux-amd64_c2s16-perf_vs_release" swarming_host: "chromium-swarm.appspot.com" @@ -198794,6 +198912,59 @@ buckets { enable: true } } + builders { + name: "x_tools-go1.23-linux-amd64-typesalias" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.ci-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 0,' + ' "project": "tools",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" swarming_host: "chromium-swarm.appspot.com" @@ -201456,6 +201627,59 @@ buckets { enable: true } } + builders { + name: "x_tools-gotip-linux-amd64-typesalias" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.ci-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 0,' + ' "project": "tools",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "x_tools-gotip-linux-arm" swarming_host: "chromium-swarm.appspot.com" @@ -233449,10 +233673,10 @@ buckets { } } builders { - name: "go1.23-linux-arm64-boringcrypto-build_go" + name: "go1.23-linux-amd64-typesalias-build_go" swarming_host: "chromium-swarm.appspot.com" - dimensions: "cipd_platform:linux-arm64" - dimensions: "machine_type:t2a-standard-8" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" dimensions: "os:Debian-11" dimensions: "pool:luci.golang.ci-workers" exe { @@ -233465,20 +233689,20 @@ buckets { ' "bootstrap_version": "1.20.6",' ' "build_mode": {},' ' "env": {' - ' "GOEXPERIMENT": "boringcrypto"' + ' "GODEBUG": "gotypesalias=1"' ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' ' "host": {' - ' "goarch": "arm64",' + ' "goarch": "amd64",' ' "goos": "linux"' ' },' ' "is_google": true,' ' "mode": 2,' ' "project": "go",' ' "target": {' - ' "goarch": "arm64",' + ' "goarch": "amd64",' ' "goos": "linux"' ' },' ' "tools_cache": "tools"' @@ -233505,10 +233729,10 @@ buckets { } } builders { - name: "go1.23-linux-arm64-boringcrypto-test_only" + name: "go1.23-linux-amd64-typesalias-test_only" swarming_host: "chromium-swarm.appspot.com" - dimensions: "cipd_platform:linux-arm64" - dimensions: "machine_type:t2a-standard-8" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" dimensions: "os:Debian-11" dimensions: "pool:luci.golang.ci-workers" exe { @@ -233520,20 +233744,20 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "env": {' - ' "GOEXPERIMENT": "boringcrypto"' + ' "GODEBUG": "gotypesalias=1"' ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' ' "host": {' - ' "goarch": "arm64",' + ' "goarch": "amd64",' ' "goos": "linux"' ' },' ' "is_google": true,' ' "mode": 3,' ' "project": "go",' ' "target": {' - ' "goarch": "arm64",' + ' "goarch": "amd64",' ' "goos": "linux"' ' },' ' "test_mode": {},' @@ -233566,7 +233790,7 @@ buckets { } } builders { - name: "go1.23-linux-arm64-build_go" + name: "go1.23-linux-arm64-boringcrypto-build_go" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-arm64" dimensions: "machine_type:t2a-standard-8" @@ -233581,7 +233805,9 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "build_mode": {},' - ' "env": {},' + ' "env": {' + ' "GOEXPERIMENT": "boringcrypto"' + ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' @@ -233620,7 +233846,7 @@ buckets { } } builders { - name: "go1.23-linux-arm64-longtest-build_go" + name: "go1.23-linux-arm64-boringcrypto-test_only" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-arm64" dimensions: "machine_type:t2a-standard-8" @@ -233634,8 +233860,9 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "build_mode": {},' - ' "env": {},' + ' "env": {' + ' "GOEXPERIMENT": "boringcrypto"' + ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' @@ -233644,14 +233871,128 @@ buckets { ' "goos": "linux"' ' },' ' "is_google": true,' - ' "long_test": true,' - ' "mode": 2,' + ' "mode": 3,' ' "project": "go",' ' "target": {' ' "goarch": "arm64",' ' "goos": "linux"' ' },' - ' "test_timeout_scale": 5,' + ' "test_mode": {},' + ' "test_shard": {' + ' "num_shards": 1,' + ' "shard_id": 0' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + allowed_property_overrides: "test_shard" + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "go1.23-linux-arm64-build_go" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-arm64" + dimensions: "machine_type:t2a-standard-8" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.ci-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' + ' "env": {},' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "arm64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 2,' + ' "project": "go",' + ' "target": {' + ' "goarch": "arm64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "go1.23-linux-arm64-longtest-build_go" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-arm64" + dimensions: "machine_type:t2a-standard-8" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.ci-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' + ' "env": {},' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "arm64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "long_test": true,' + ' "mode": 2,' + ' "project": "go",' + ' "target": {' + ' "goarch": "arm64",' + ' "goos": "linux"' + ' },' + ' "test_timeout_scale": 5,' ' "tools_cache": "tools"' '}' allowed_property_overrides: "go_commit" @@ -237061,6 +237402,123 @@ buckets { enable: true } } + builders { + name: "gotip-linux-amd64-typesalias-build_go" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.ci-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 2,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "gotip-linux-amd64-typesalias-test_only" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.ci-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 3,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "test_mode": {},' + ' "test_shard": {' + ' "num_shards": 1,' + ' "shard_id": 0' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + allowed_property_overrides: "test_shard" + priority: 40 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "gotip-linux-arm64-boringcrypto-build_go" swarming_host: "chromium-swarm.appspot.com" @@ -251728,12 +252186,10 @@ buckets { } } builders { - name: "go1.23-linux-amd64_c2s16-perf_vs_parent" + name: "go1.23-linux-amd64-typesalias" swarming_host: "chrome-swarming.appspot.com" dimensions: "cipd_platform:linux-amd64" - dimensions: "machine_type:c2-standard-16" - dimensions: "os:Debian-12" - dimensions: "pool:luci.golang.security-try-workers" + dimensions: "pool:luci.golang.security-try" exe { cipd_package: "infra/experimental/golangbuild/${platform}" cipd_version: "latest" @@ -251742,7 +252198,15 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "env": {},' + ' "coord_mode": {' + ' "build_builder": "golang/security-try-workers/go1.23-linux-amd64-typesalias-build_go",' + ' "builders_to_trigger_after_toolchain_build": [],' + ' "num_test_shards": 4,' + ' "test_builder": "golang/security-try-workers/go1.23-linux-amd64-typesalias-test_only"' + ' },' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "host": {' @@ -251750,10 +252214,7 @@ buckets { ' "goos": "linux"' ' },' ' "is_google": true,' - ' "mode": 4,' - ' "perf_mode": {' - ' "baseline": "parent"' - ' },' + ' "mode": 1,' ' "project": "go",' ' "target": {' ' "goarch": "amd64",' @@ -251762,7 +252223,6 @@ buckets { ' "tools_cache": "tools"' '}' priority: 30 - execution_timeout_secs: 43200 expiration_secs: 21600 wait_for_capacity: NO caches { @@ -251773,7 +252233,7 @@ buckets { name: "tools" path: "tools" } - service_account: "security-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + service_account: "security-coordinator-builder@golang-ci-luci.iam.gserviceaccount.com" experiments { key: "golang.shard_by_weight" value: 100 @@ -251783,7 +252243,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64_c2s16-perf_vs_release" + name: "go1.23-linux-amd64_c2s16-perf_vs_parent" swarming_host: "chrome-swarming.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:c2-standard-16" @@ -251807,7 +252267,7 @@ buckets { ' "is_google": true,' ' "mode": 4,' ' "perf_mode": {' - ' "baseline": "latest_go_release"' + ' "baseline": "parent"' ' },' ' "project": "go",' ' "target": {' @@ -251838,7 +252298,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64_c2s16-perf_vs_tip" + name: "go1.23-linux-amd64_c2s16-perf_vs_release" swarming_host: "chrome-swarming.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:c2-standard-16" @@ -251862,7 +252322,7 @@ buckets { ' "is_google": true,' ' "mode": 4,' ' "perf_mode": {' - ' "baseline": "refs/heads/master"' + ' "baseline": "latest_go_release"' ' },' ' "project": "go",' ' "target": {' @@ -251893,10 +252353,10 @@ buckets { } } builders { - name: "go1.23-linux-amd64_c3h88-perf_vs_parent" + name: "go1.23-linux-amd64_c2s16-perf_vs_tip" swarming_host: "chrome-swarming.appspot.com" dimensions: "cipd_platform:linux-amd64" - dimensions: "machine_type:c3-highcpu-88" + dimensions: "machine_type:c2-standard-16" dimensions: "os:Debian-12" dimensions: "pool:luci.golang.security-try-workers" exe { @@ -251917,7 +252377,62 @@ buckets { ' "is_google": true,' ' "mode": 4,' ' "perf_mode": {' - ' "baseline": "parent"' + ' "baseline": "refs/heads/master"' + ' },' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 30 + execution_timeout_secs: 43200 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "security-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "go1.23-linux-amd64_c3h88-perf_vs_parent" + swarming_host: "chrome-swarming.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:c3-highcpu-88" + dimensions: "os:Debian-12" + dimensions: "pool:luci.golang.security-try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {},' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 4,' + ' "perf_mode": {' + ' "baseline": "parent"' ' },' ' "project": "go",' ' "target": {' @@ -254233,6 +254748,63 @@ buckets { enable: true } } + builders { + name: "gotip-linux-amd64-typesalias" + swarming_host: "chrome-swarming.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "pool:luci.golang.security-try" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "coord_mode": {' + ' "build_builder": "golang/security-try-workers/gotip-linux-amd64-typesalias-build_go",' + ' "builders_to_trigger_after_toolchain_build": [],' + ' "num_test_shards": 4,' + ' "test_builder": "golang/security-try-workers/gotip-linux-amd64-typesalias-test_only"' + ' },' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 1,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "security-coordinator-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "gotip-linux-amd64_c2s16-perf_vs_parent" swarming_host: "chrome-swarming.appspot.com" @@ -276951,6 +277523,123 @@ buckets { enable: true } } + builders { + name: "go1.23-linux-amd64-typesalias-build_go" + swarming_host: "chrome-swarming.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.security-try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 2,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "security-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "go1.23-linux-amd64-typesalias-test_only" + swarming_host: "chrome-swarming.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.security-try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 3,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "test_mode": {},' + ' "test_shard": {' + ' "num_shards": 1,' + ' "shard_id": 0' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + allowed_property_overrides: "test_shard" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "security-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "go1.23-linux-arm64-boringcrypto-build_go" swarming_host: "chrome-swarming.appspot.com" @@ -280564,6 +281253,123 @@ buckets { enable: true } } + builders { + name: "gotip-linux-amd64-typesalias-build_go" + swarming_host: "chrome-swarming.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.security-try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 2,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "security-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "gotip-linux-amd64-typesalias-test_only" + swarming_host: "chrome-swarming.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.security-try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 3,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "test_mode": {},' + ' "test_shard": {' + ' "num_shards": 1,' + ' "shard_id": 0' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + allowed_property_overrides: "test_shard" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "security-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "gotip-linux-arm64-boringcrypto-build_go" swarming_host: "chrome-swarming.appspot.com" @@ -294328,6 +295134,63 @@ buckets { enable: true } } + builders { + name: "go1.23-linux-amd64-typesalias" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "pool:luci.golang.try" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "coord_mode": {' + ' "build_builder": "golang/try-workers/go1.23-linux-amd64-typesalias-build_go",' + ' "builders_to_trigger_after_toolchain_build": [],' + ' "num_test_shards": 4,' + ' "test_builder": "golang/try-workers/go1.23-linux-amd64-typesalias-test_only"' + ' },' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 1,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "coordinator-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "go1.23-linux-amd64_c2s16-perf_vs_parent" swarming_host: "chromium-swarm.appspot.com" @@ -298696,7 +299559,66 @@ buckets { } } builders { - name: "gotip-linux-amd64-longtest-swissmap" + name: "gotip-linux-amd64-longtest-swissmap" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "pool:luci.golang.try" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "coord_mode": {' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-longtest-swissmap-build_go",' + ' "builders_to_trigger_after_toolchain_build": [],' + ' "num_test_shards": 4,' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-longtest-swissmap-test_only"' + ' },' + ' "env": {' + ' "GOEXPERIMENT": "swissmap"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "long_test": true,' + ' "mode": 1,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "test_timeout_scale": 5,' + ' "tools_cache": "tools"' + '}' + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "coordinator-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "gotip-linux-amd64-misccompile" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -298708,15 +299630,14 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' + ' "compile_only": true,' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-longtest-swissmap-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-misccompile-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' - ' "num_test_shards": 4,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-longtest-swissmap-test_only"' - ' },' - ' "env": {' - ' "GOEXPERIMENT": "swissmap"' + ' "num_test_shards": 12,' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-misccompile-test_only"' ' },' + ' "env": {},' ' "git_cache": "git",' ' "go_branch": "master",' ' "host": {' @@ -298724,14 +299645,13 @@ buckets { ' "goos": "linux"' ' },' ' "is_google": true,' - ' "long_test": true,' + ' "misc_ports": true,' ' "mode": 1,' ' "project": "go",' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' ' },' - ' "test_timeout_scale": 5,' ' "tools_cache": "tools"' '}' priority: 30 @@ -298755,7 +299675,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-misccompile" + name: "gotip-linux-amd64-newinliner" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -298767,14 +299687,15 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "compile_only": true,' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-misccompile-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-newinliner-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' - ' "num_test_shards": 12,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-misccompile-test_only"' + ' "num_test_shards": 4,' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-newinliner-test_only"' + ' },' + ' "env": {' + ' "GOEXPERIMENT": "newinliner"' ' },' - ' "env": {},' ' "git_cache": "git",' ' "go_branch": "master",' ' "host": {' @@ -298782,7 +299703,6 @@ buckets { ' "goos": "linux"' ' },' ' "is_google": true,' - ' "misc_ports": true,' ' "mode": 1,' ' "project": "go",' ' "target": {' @@ -298812,7 +299732,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-newinliner" + name: "gotip-linux-amd64-nocgo" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -298825,13 +299745,13 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-newinliner-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-nocgo-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' ' "num_test_shards": 4,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-newinliner-test_only"' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-nocgo-test_only"' ' },' ' "env": {' - ' "GOEXPERIMENT": "newinliner"' + ' "CGO_ENABLED": "0"' ' },' ' "git_cache": "git",' ' "go_branch": "master",' @@ -298869,7 +299789,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-nocgo" + name: "gotip-linux-amd64-noopt" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -298882,13 +299802,13 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-nocgo-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-noopt-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' ' "num_test_shards": 4,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-nocgo-test_only"' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-noopt-test_only"' ' },' ' "env": {' - ' "CGO_ENABLED": "0"' + ' "GO_GCFLAGS": "-N -l"' ' },' ' "git_cache": "git",' ' "go_branch": "master",' @@ -298926,7 +299846,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-noopt" + name: "gotip-linux-amd64-race" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -298939,14 +299859,12 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-noopt-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-race-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' ' "num_test_shards": 4,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-noopt-test_only"' - ' },' - ' "env": {' - ' "GO_GCFLAGS": "-N -l"' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-race-test_only"' ' },' + ' "env": {},' ' "git_cache": "git",' ' "go_branch": "master",' ' "host": {' @@ -298956,10 +299874,12 @@ buckets { ' "is_google": true,' ' "mode": 1,' ' "project": "go",' + ' "race_mode": true,' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' ' },' + ' "test_timeout_scale": 2,' ' "tools_cache": "tools"' '}' priority: 30 @@ -298983,7 +299903,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-race" + name: "gotip-linux-amd64-racecompile" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -298995,11 +299915,13 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' + ' "compile_only": true,' + ' "compiler_linker_race_mode": true,' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-race-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-racecompile-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' - ' "num_test_shards": 4,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-race-test_only"' + ' "num_test_shards": 1,' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-racecompile-test_only"' ' },' ' "env": {},' ' "git_cache": "git",' @@ -299011,12 +299933,10 @@ buckets { ' "is_google": true,' ' "mode": 1,' ' "project": "go",' - ' "race_mode": true,' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' ' },' - ' "test_timeout_scale": 2,' ' "tools_cache": "tools"' '}' priority: 30 @@ -299040,7 +299960,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-racecompile" + name: "gotip-linux-amd64-ssacheck" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -299053,14 +299973,15 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "compile_only": true,' - ' "compiler_linker_race_mode": true,' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-racecompile-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-ssacheck-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' ' "num_test_shards": 1,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-racecompile-test_only"' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-ssacheck-test_only"' + ' },' + ' "env": {' + ' "GO_GCFLAGS": "-d=ssa/check/on"' ' },' - ' "env": {},' ' "git_cache": "git",' ' "go_branch": "master",' ' "host": {' @@ -299097,7 +300018,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-ssacheck" + name: "gotip-linux-amd64-staticlockranking" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -299109,15 +300030,14 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "compile_only": true,' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-ssacheck-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-staticlockranking-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' - ' "num_test_shards": 1,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-ssacheck-test_only"' + ' "num_test_shards": 4,' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-staticlockranking-test_only"' ' },' ' "env": {' - ' "GO_GCFLAGS": "-d=ssa/check/on"' + ' "GOEXPERIMENT": "staticlockranking"' ' },' ' "git_cache": "git",' ' "go_branch": "master",' @@ -299155,7 +300075,7 @@ buckets { } } builders { - name: "gotip-linux-amd64-staticlockranking" + name: "gotip-linux-amd64-typesalias" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "pool:luci.golang.try" @@ -299168,13 +300088,13 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "coord_mode": {' - ' "build_builder": "golang/try-workers/gotip-linux-amd64-staticlockranking-build_go",' + ' "build_builder": "golang/try-workers/gotip-linux-amd64-typesalias-build_go",' ' "builders_to_trigger_after_toolchain_build": [],' ' "num_test_shards": 4,' - ' "test_builder": "golang/try-workers/gotip-linux-amd64-staticlockranking-test_only"' + ' "test_builder": "golang/try-workers/gotip-linux-amd64-typesalias-test_only"' ' },' ' "env": {' - ' "GOEXPERIMENT": "staticlockranking"' + ' "GODEBUG": "gotypesalias=1"' ' },' ' "git_cache": "git",' ' "go_branch": "master",' @@ -538278,6 +539198,59 @@ buckets { enable: true } } + builders { + name: "x_tools-go1.23-linux-amd64-typesalias" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 0,' + ' "project": "tools",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" swarming_host: "chromium-swarm.appspot.com" @@ -541160,6 +542133,59 @@ buckets { enable: true } } + builders { + name: "x_tools-gotip-linux-amd64-typesalias" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 0,' + ' "project": "tools",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "x_tools-gotip-linux-amd64_c2s16-perf_vs_parent" swarming_host: "chromium-swarm.appspot.com" @@ -601694,7 +602720,63 @@ buckets { } } builders { - name: "go1.23-linux-amd64-noopt-build_go" + name: "go1.23-linux-amd64-noopt-build_go" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' + ' "env": {' + ' "GO_GCFLAGS": "-N -l"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 2,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "go1.23-linux-amd64-noopt-test_only" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -601708,7 +602790,6 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "build_mode": {},' ' "env": {' ' "GO_GCFLAGS": "-N -l"' ' },' @@ -601720,15 +602801,21 @@ buckets { ' "goos": "linux"' ' },' ' "is_google": true,' - ' "mode": 2,' + ' "mode": 3,' ' "project": "go",' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' ' },' + ' "test_mode": {},' + ' "test_shard": {' + ' "num_shards": 1,' + ' "shard_id": 0' + ' },' ' "tools_cache": "tools"' '}' allowed_property_overrides: "go_commit" + allowed_property_overrides: "test_shard" priority: 30 expiration_secs: 21600 wait_for_capacity: NO @@ -601750,7 +602837,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-noopt-test_only" + name: "go1.23-linux-amd64-race-build_go" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -601764,9 +602851,63 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "env": {' - ' "GO_GCFLAGS": "-N -l"' + ' "build_mode": {},' + ' "env": {},' + ' "git_cache": "git",' + ' "go_branch": "release-branch.go1.23",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 2,' + ' "project": "go",' + ' "race_mode": true,' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' ' },' + ' "test_timeout_scale": 2,' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "go1.23-linux-amd64-race-test_only" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {},' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' @@ -601777,6 +602918,7 @@ buckets { ' "is_google": true,' ' "mode": 3,' ' "project": "go",' + ' "race_mode": true,' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' @@ -601786,6 +602928,7 @@ buckets { ' "num_shards": 1,' ' "shard_id": 0' ' },' + ' "test_timeout_scale": 2,' ' "tools_cache": "tools"' '}' allowed_property_overrides: "go_commit" @@ -601811,7 +602954,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-race-build_go" + name: "go1.23-linux-amd64-racecompile-build_go" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -601826,6 +602969,8 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "build_mode": {},' + ' "compile_only": true,' + ' "compiler_linker_race_mode": true,' ' "env": {},' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' @@ -601837,12 +602982,10 @@ buckets { ' "is_google": true,' ' "mode": 2,' ' "project": "go",' - ' "race_mode": true,' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' ' },' - ' "test_timeout_scale": 2,' ' "tools_cache": "tools"' '}' allowed_property_overrides: "go_commit" @@ -601867,7 +603010,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-race-test_only" + name: "go1.23-linux-amd64-racecompile-test_only" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -601881,6 +603024,8 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' + ' "compile_only": true,' + ' "compiler_linker_race_mode": true,' ' "env": {},' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' @@ -601892,7 +603037,6 @@ buckets { ' "is_google": true,' ' "mode": 3,' ' "project": "go",' - ' "race_mode": true,' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' @@ -601902,7 +603046,6 @@ buckets { ' "num_shards": 1,' ' "shard_id": 0' ' },' - ' "test_timeout_scale": 2,' ' "tools_cache": "tools"' '}' allowed_property_overrides: "go_commit" @@ -601928,7 +603071,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-racecompile-build_go" + name: "go1.23-linux-amd64-ssacheck-build_go" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -601944,8 +603087,9 @@ buckets { ' "bootstrap_version": "1.20.6",' ' "build_mode": {},' ' "compile_only": true,' - ' "compiler_linker_race_mode": true,' - ' "env": {},' + ' "env": {' + ' "GO_GCFLAGS": "-d=ssa/check/on"' + ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' @@ -601984,7 +603128,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-racecompile-test_only" + name: "go1.23-linux-amd64-ssacheck-test_only" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -601999,8 +603143,9 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "compile_only": true,' - ' "compiler_linker_race_mode": true,' - ' "env": {},' + ' "env": {' + ' "GO_GCFLAGS": "-d=ssa/check/on"' + ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' @@ -602045,7 +603190,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-ssacheck-build_go" + name: "go1.23-linux-amd64-staticlockranking-build_go" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -602060,9 +603205,8 @@ buckets { '{' ' "bootstrap_version": "1.20.6",' ' "build_mode": {},' - ' "compile_only": true,' ' "env": {' - ' "GO_GCFLAGS": "-d=ssa/check/on"' + ' "GOEXPERIMENT": "staticlockranking"' ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' @@ -602102,7 +603246,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-ssacheck-test_only" + name: "go1.23-linux-amd64-staticlockranking-test_only" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -602116,9 +603260,8 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "compile_only": true,' ' "env": {' - ' "GO_GCFLAGS": "-d=ssa/check/on"' + ' "GOEXPERIMENT": "staticlockranking"' ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' @@ -602164,7 +603307,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-staticlockranking-build_go" + name: "go1.23-linux-amd64-test_only" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -602178,10 +603321,7 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "build_mode": {},' - ' "env": {' - ' "GOEXPERIMENT": "staticlockranking"' - ' },' + ' "env": {},' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' @@ -602190,15 +603330,22 @@ buckets { ' "goos": "linux"' ' },' ' "is_google": true,' - ' "mode": 2,' + ' "mode": 3,' + ' "no_network": true,' ' "project": "go",' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' ' },' + ' "test_mode": {},' + ' "test_shard": {' + ' "num_shards": 1,' + ' "shard_id": 0' + ' },' ' "tools_cache": "tools"' '}' allowed_property_overrides: "go_commit" + allowed_property_overrides: "test_shard" priority: 30 expiration_secs: 21600 wait_for_capacity: NO @@ -602220,7 +603367,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-staticlockranking-test_only" + name: "go1.23-linux-amd64-typesalias-build_go" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -602234,8 +603381,9 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' ' "env": {' - ' "GOEXPERIMENT": "staticlockranking"' + ' "GODEBUG": "gotypesalias=1"' ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' @@ -602245,21 +603393,15 @@ buckets { ' "goos": "linux"' ' },' ' "is_google": true,' - ' "mode": 3,' + ' "mode": 2,' ' "project": "go",' ' "target": {' ' "goarch": "amd64",' ' "goos": "linux"' ' },' - ' "test_mode": {},' - ' "test_shard": {' - ' "num_shards": 1,' - ' "shard_id": 0' - ' },' ' "tools_cache": "tools"' '}' allowed_property_overrides: "go_commit" - allowed_property_overrides: "test_shard" priority: 30 expiration_secs: 21600 wait_for_capacity: NO @@ -602281,7 +603423,7 @@ buckets { } } builders { - name: "go1.23-linux-amd64-test_only" + name: "go1.23-linux-amd64-typesalias-test_only" swarming_host: "chromium-swarm.appspot.com" dimensions: "cipd_platform:linux-amd64" dimensions: "machine_type:n1-standard-16" @@ -602295,7 +603437,9 @@ buckets { properties: '{' ' "bootstrap_version": "1.20.6",' - ' "env": {},' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' ' "git_cache": "git",' ' "go_branch": "release-branch.go1.23",' ' "go_commit": "",' @@ -602305,7 +603449,6 @@ buckets { ' },' ' "is_google": true,' ' "mode": 3,' - ' "no_network": true,' ' "project": "go",' ' "target": {' ' "goarch": "amd64",' @@ -605953,6 +607096,123 @@ buckets { enable: true } } + builders { + name: "gotip-linux-amd64-typesalias-build_go" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "build_mode": {},' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 2,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } + builders { + name: "gotip-linux-amd64-typesalias-test_only" + swarming_host: "chromium-swarm.appspot.com" + dimensions: "cipd_platform:linux-amd64" + dimensions: "machine_type:n1-standard-16" + dimensions: "os:Debian-11" + dimensions: "pool:luci.golang.try-workers" + exe { + cipd_package: "infra/experimental/golangbuild/${platform}" + cipd_version: "latest" + cmd: "golangbuild" + } + properties: + '{' + ' "bootstrap_version": "1.20.6",' + ' "env": {' + ' "GODEBUG": "gotypesalias=1"' + ' },' + ' "git_cache": "git",' + ' "go_branch": "master",' + ' "go_commit": "",' + ' "host": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "is_google": true,' + ' "mode": 3,' + ' "project": "go",' + ' "target": {' + ' "goarch": "amd64",' + ' "goos": "linux"' + ' },' + ' "test_mode": {},' + ' "test_shard": {' + ' "num_shards": 1,' + ' "shard_id": 0' + ' },' + ' "tools_cache": "tools"' + '}' + allowed_property_overrides: "go_commit" + allowed_property_overrides: "test_shard" + priority: 30 + expiration_secs: 21600 + wait_for_capacity: NO + caches { + name: "git" + path: "git" + } + caches { + name: "tools" + path: "tools" + } + service_account: "public-worker-builder@golang-ci-luci.iam.gserviceaccount.com" + experiments { + key: "golang.shard_by_weight" + value: 100 + } + resultdb { + enable: true + } + } builders { name: "gotip-linux-arm64-boringcrypto-build_go" swarming_host: "chromium-swarm.appspot.com" diff --git a/generated/luci-milo.cfg b/generated/luci-milo.cfg index eeb4d1cb39..82085053e5 100644 --- a/generated/luci-milo.cfg +++ b/generated/luci-milo.cfg @@ -162,6 +162,11 @@ consoles { category: "linux|amd64" short_name: "staticlockranking" } + builders { + name: "buildbucket/luci.golang.ci/gotip-linux-amd64-typesalias" + category: "linux|amd64" + short_name: "typesalias" + } builders { name: "buildbucket/luci.golang.ci/gotip-linux-amd64_c2s16-perf_vs_release" category: "linux|amd64_c2s16" @@ -419,6 +424,11 @@ consoles { category: "linux|amd64" short_name: "staticlockranking" } + builders { + name: "buildbucket/luci.golang.ci/go1.23-linux-amd64-typesalias" + category: "linux|amd64" + short_name: "typesalias" + } builders { name: "buildbucket/luci.golang.ci/go1.23-linux-amd64_c2s16-perf_vs_release" category: "linux|amd64_c2s16" @@ -15952,6 +15962,11 @@ consoles { category: "linux|amd64" short_name: "race" } + builders { + name: "buildbucket/luci.golang.ci/x_tools-gotip-linux-amd64-typesalias" + category: "linux|amd64" + short_name: "typesalias" + } builders { name: "buildbucket/luci.golang.ci/x_tools-gotip-linux-arm" category: "linux|arm" @@ -16162,6 +16177,11 @@ consoles { category: "linux|amd64" short_name: "race" } + builders { + name: "buildbucket/luci.golang.ci/x_tools-go1.23-linux-amd64-typesalias" + category: "linux|amd64" + short_name: "typesalias" + } builders { name: "buildbucket/luci.golang.ci/x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" category: "linux|amd64_c2s16" @@ -32531,6 +32551,11 @@ consoles { category: "linux|amd64" short_name: "race" } + builders { + name: "buildbucket/luci.golang.ci/x_tools-gotip-linux-amd64-typesalias" + category: "linux|amd64" + short_name: "typesalias" + } builders { name: "buildbucket/luci.golang.ci/x_tools-gotip-linux-arm" category: "linux|arm" @@ -32741,6 +32766,11 @@ consoles { category: "linux|amd64" short_name: "race" } + builders { + name: "buildbucket/luci.golang.ci/x_tools-go1.23-linux-amd64-typesalias" + category: "linux|amd64" + short_name: "typesalias" + } builders { name: "buildbucket/luci.golang.ci/x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" category: "linux|amd64_c2s16" @@ -46537,6 +46567,9 @@ consoles { builders { name: "buildbucket/luci.golang.ci/gotip-linux-amd64-staticlockranking" } + builders { + name: "buildbucket/luci.golang.ci/gotip-linux-amd64-typesalias" + } builders { name: "buildbucket/luci.golang.ci/gotip-linux-amd64_c2s16-perf_vs_release" } @@ -46585,6 +46618,9 @@ consoles { builders { name: "buildbucket/luci.golang.ci/go1.23-linux-amd64-staticlockranking" } + builders { + name: "buildbucket/luci.golang.ci/go1.23-linux-amd64-typesalias" + } builders { name: "buildbucket/luci.golang.ci/go1.23-linux-amd64_c2s16-perf_vs_release" } @@ -48643,6 +48679,9 @@ consoles { builders { name: "buildbucket/luci.golang.ci/x_tools-gotip-linux-amd64-race" } + builders { + name: "buildbucket/luci.golang.ci/x_tools-gotip-linux-amd64-typesalias" + } builders { name: "buildbucket/luci.golang.ci/x_tools-go1.20-linux-amd64" } @@ -48670,6 +48709,9 @@ consoles { builders { name: "buildbucket/luci.golang.ci/x_tools-go1.23-linux-amd64-race" } + builders { + name: "buildbucket/luci.golang.ci/x_tools-go1.23-linux-amd64-typesalias" + } builders { name: "buildbucket/luci.golang.ci/x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" } diff --git a/generated/luci-scheduler.cfg b/generated/luci-scheduler.cfg index 134a0feb33..1ef6f0d4a2 100644 --- a/generated/luci-scheduler.cfg +++ b/generated/luci-scheduler.cfg @@ -3348,6 +3348,22 @@ job { builder: "go1.23-linux-amd64-staticlockranking" } } +job { + id: "go1.23-linux-amd64-typesalias" + realm: "ci" + triggering_policy { + kind: NEWEST_FIRST + max_concurrent_invocations: 5 + pending_timeout { + seconds: 604800 + } + } + buildbucket { + server: "cr-buildbucket.appspot.com" + bucket: "ci" + builder: "go1.23-linux-amd64-typesalias" + } +} job { id: "go1.23-linux-amd64_c2s16-perf_vs_release" realm: "ci" @@ -4708,6 +4724,22 @@ job { builder: "gotip-linux-amd64-staticlockranking" } } +job { + id: "gotip-linux-amd64-typesalias" + realm: "ci" + triggering_policy { + kind: NEWEST_FIRST + max_concurrent_invocations: 5 + pending_timeout { + seconds: 604800 + } + } + buildbucket { + server: "cr-buildbucket.appspot.com" + bucket: "ci" + builder: "gotip-linux-amd64-typesalias" + } +} job { id: "gotip-linux-amd64_c2s16-perf_vs_release" realm: "ci" @@ -59229,6 +59261,22 @@ job { builder: "x_tools-go1.23-linux-amd64-race" } } +job { + id: "x_tools-go1.23-linux-amd64-typesalias" + realm: "ci" + triggering_policy { + kind: NEWEST_FIRST + max_concurrent_invocations: 5 + pending_timeout { + seconds: 604800 + } + } + buildbucket { + server: "cr-buildbucket.appspot.com" + bucket: "ci" + builder: "x_tools-go1.23-linux-amd64-typesalias" + } +} job { id: "x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" realm: "ci" @@ -60029,6 +60077,22 @@ job { builder: "x_tools-gotip-linux-amd64-race" } } +job { + id: "x_tools-gotip-linux-amd64-typesalias" + realm: "ci" + triggering_policy { + kind: NEWEST_FIRST + max_concurrent_invocations: 5 + pending_timeout { + seconds: 604800 + } + } + buildbucket { + server: "cr-buildbucket.appspot.com" + bucket: "ci" + builder: "x_tools-gotip-linux-amd64-typesalias" + } +} job { id: "x_tools-gotip-linux-arm" realm: "ci" @@ -69376,6 +69440,7 @@ trigger { triggers: "go1.23-linux-amd64-racecompile" triggers: "go1.23-linux-amd64-ssacheck" triggers: "go1.23-linux-amd64-staticlockranking" + triggers: "go1.23-linux-amd64-typesalias" triggers: "go1.23-linux-amd64_c2s16-perf_vs_release" triggers: "go1.23-linux-amd64_c3h88-perf_vs_release" triggers: "go1.23-linux-arm" @@ -69469,6 +69534,7 @@ trigger { triggers: "gotip-linux-amd64-racecompile" triggers: "gotip-linux-amd64-ssacheck" triggers: "gotip-linux-amd64-staticlockranking" + triggers: "gotip-linux-amd64-typesalias" triggers: "gotip-linux-amd64_c2s16-perf_vs_release" triggers: "gotip-linux-amd64_c3h88-perf_vs_release" triggers: "gotip-linux-arm" @@ -74424,6 +74490,7 @@ trigger { triggers: "x_tools-go1.23-linux-amd64-misccompile" triggers: "x_tools-go1.23-linux-amd64-nocgo" triggers: "x_tools-go1.23-linux-amd64-race" + triggers: "x_tools-go1.23-linux-amd64-typesalias" triggers: "x_tools-go1.23-linux-amd64_c2s16-perf_vs_gopls_0_11" triggers: "x_tools-go1.23-linux-arm" triggers: "x_tools-go1.23-linux-arm64" @@ -74522,6 +74589,7 @@ trigger { triggers: "x_tools-gotip-linux-amd64-misccompile" triggers: "x_tools-gotip-linux-amd64-nocgo" triggers: "x_tools-gotip-linux-amd64-race" + triggers: "x_tools-gotip-linux-amd64-typesalias" triggers: "x_tools-gotip-linux-arm" triggers: "x_tools-gotip-linux-arm64" triggers: "x_tools-gotip-linux-arm64-boringcrypto" diff --git a/main.star b/main.star index de9f460f07..918085ecc5 100755 --- a/main.star +++ b/main.star @@ -796,6 +796,25 @@ def define_for_projects_except(projects): return f +# define_for_issue68798 is a custom policy for go.dev/issue/68798. +# It shouldn't be needed beyond Go 1.24. +def define_for_issue68798(): + def f(port, project, go_branch_short): + exists = project in ["go", "tools"] + if go_branch_short != "gotip" and go_branch_short <= "go1.22": + # The builder exists as optional presubmit up to Go 1.22, + # since gotypesalias=0 was the default back then and not + # all tests are guaranteed to pass. + presubmit, postsubmit = False, False + else: + # Starting with Go 1.23, gotypesalias=1 is the default, so + # a builder that sets it explicitly in the environment is expected to be a no-op. + # Run it anyway to confirm that's the case for reasons motivated in go.dev/issue/68798. + presubmit, postsubmit = False, True + return (exists, presubmit, postsubmit, []) + + return f + # RUN_MODS is a list of valid run-time modifications to the way we # build and test our various projects. RUN_MODS = dict( @@ -959,11 +978,9 @@ RUN_MODS = dict( # Build and test with the gotypesalias GODEBUG, which enables # explicit representation of type aliases. - # - # The builder exists only up to Go 1.22 since gotypesalias=1 is the default in Go 1.23+. typesalias = make_run_mod( add_env = {"GODEBUG": "gotypesalias=1"}, - enabled = define_for_optional_presubmit_only_ending_at(["go", "tools"], "go1.22"), + enabled = define_for_issue68798(), ), )