From 6a17782ed25ba4ccd2adf191990cc32e65c3934c Mon Sep 17 00:00:00 2001
From: sam boyer <tech@samboyer.org>
Date: Tue, 25 Jul 2017 00:22:22 -0400
Subject: [PATCH] Remove some old TODOs that no longer apply

---
 analyzer.go                     | 3 +--
 internal/gps/bridge.go          | 2 --
 internal/gps/constraint_test.go | 3 ---
 internal/gps/result.go          | 1 -
 4 files changed, 1 insertion(+), 8 deletions(-)

diff --git a/analyzer.go b/analyzer.go
index 2e4b6fa30a..9872a3aa03 100644
--- a/analyzer.go
+++ b/analyzer.go
@@ -40,8 +40,7 @@ func (a Analyzer) DeriveManifestAndLock(path string, n gps.ProjectRoot) (gps.Man
 	if err != nil {
 		return nil, nil, err
 	}
-	// TODO: No need to return lock til we decide about preferred versions, see
-	// https://github.com/sdboyer/gps/wiki/gps-for-Implementors#preferred-versions.
+
 	return m, nil, nil
 }
 
diff --git a/internal/gps/bridge.go b/internal/gps/bridge.go
index 5ac75ff565..b43bac369f 100644
--- a/internal/gps/bridge.go
+++ b/internal/gps/bridge.go
@@ -201,8 +201,6 @@ func (b *bridge) breakLock() {
 
 	for _, lp := range b.s.rd.rl.Projects() {
 		if _, is := b.s.sel.selected(lp.pi); !is {
-			// TODO(sdboyer) use this as an opportunity to detect
-			// inconsistencies between upstream and the lock (e.g., moved tags)?
 			pi, v := lp.pi, lp.Version()
 			go func() {
 				// Sync first
diff --git a/internal/gps/constraint_test.go b/internal/gps/constraint_test.go
index b37ea17071..b10edc0dc0 100644
--- a/internal/gps/constraint_test.go
+++ b/internal/gps/constraint_test.go
@@ -95,9 +95,6 @@ func TestBranchConstraintOps(t *testing.T) {
 	}
 
 	// Now add same rev to different branches
-	// TODO(sdboyer) this might not actually be a good idea, when you consider the
-	// semantics of floating versions...matching on an underlying rev might be
-	// nice in the short term, but it's probably shit most of the time
 	v5 := v2.Pair(Revision("snuffleupagus")).(versionPair)
 	if !v5.Matches(v3) {
 		t.Errorf("%s should match %s", gu(v5), gu(v3))
diff --git a/internal/gps/result.go b/internal/gps/result.go
index eb9d6ad0e1..504b02368b 100644
--- a/internal/gps/result.go
+++ b/internal/gps/result.go
@@ -73,7 +73,6 @@ func WriteDepTree(basedir string, l Lock, sm SourceManager, sv bool) error {
 		if sv {
 			filepath.Walk(to, stripVendor)
 		}
-		// TODO(sdboyer) dump version metadata file
 	}
 
 	return nil