Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

Possible ensure bug #284

Closed
tro3 opened this issue Mar 4, 2017 · 2 comments
Closed

Possible ensure bug #284

tro3 opened this issue Mar 4, 2017 · 2 comments
Labels

Comments

@tro3
Copy link
Contributor

tro3 commented Mar 4, 2017

An unexpected behavior found during adding integration tests. Test cases mentioned are in #265.

In the ensure/update test case, the initial manifest points at a fixed remote repo with version ~0.8.0. The remote repo contains both an 0.8.1 and a 1.0.0. When ensure -update is run on this case, the lock file updates to 1.0.0, but the manifest remains at ~0.8.0. I don't know the expected behavior, but one of those seems incorrect.

@carolynvs
Copy link
Collaborator

That was introduced by my PR. I think there's still some confusion on when dep should modify the manifest?

#235 (review)

@tro3
Copy link
Contributor Author

tro3 commented Mar 11, 2017

Holding for upgraded init definition

@tro3 tro3 closed this as completed Mar 11, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants