-
Notifications
You must be signed in to change notification settings - Fork 1k
remove git binary dependency #424
Comments
From @sdboyer on January 25, 2017 15:1 Awesome! I'd love to get rid of the binary dependency, and wouldn't mind avoiding cgo-derived complications from relying on libgit2, either. At the same time, libgit2 offers guarantees about comparable behavior to git itself that I don't know if go-git also offers. If there's anything public/explicit about such guarantees, could you point me to them? There'd be two basic ways of going about this - either contributing the changes to Masterminds/vcs, or making them directly here. I lean towards the latter, because I expect we'd be able to take advantage of optimizations that would be difficult/a bad idea to try to represent in that project's cross-vcs interface. |
From @mcuadros on January 25, 2017 15:17
I prefer do the implementation here since, having as interfaces, as you mention will be a problem. |
From @sdboyer on January 25, 2017 15:43 sounds good enough to me to get started on a PR, at the very least :) The two things I'd highlight as needing close attention are submodule cleanup (see Masterminds/vcs#60) and the export behavior. The latter could really be optimized once things like vendor pruning (#120) settle. |
From @mcuadros on January 26, 2017 9:49 Oh, I didn't though in submodules, was a more or less forgotten feature at go-git, we will work on it. And I will come back here. |
From @sdboyer on January 26, 2017 12:17 Yeah, I also basically wish they didn't exist (as evidenced by the title of that issue). I look forward to it! |
This seems like it probably won't be feasible anytime soon. Can reopen if progress actually happens. |
From @mcuadros on January 25, 2017 14:48
Using
go-git
a pure Go git implementation the dependency of the git binary can be removed, also this will give more flexibility at the time of work with git repositoriesI will be glad of make a PR with the changes suggested
Copied from original issue: sdboyer/gps#158
The text was updated successfully, but these errors were encountered: