-
Notifications
You must be signed in to change notification settings - Fork 1k
Organize GitHub Labels #610
Comments
@sdboyer I created the following labels. Let me know what you think, and if I get a 👍 I'll run through and flag existing issues with them.
|
I like the above area labels. I would like to add one more "area: testing" or something similar for things that are related to overall tests, integration tests. Or does it makes more sense to put them under shared? 🤔 Less number of labels :) Not exactly related to impacted area labels but maybe it would be helpful to also have general PR life cycle process labels to show the status of PRs. I came across some projects where there are defined phases of a PR life cycle, like design-review, code-review, docs-review and then merge. This ensures that we don't miss things like updating docs when something is changed. A clearly defined process would also help contributors to understand, prepare and submit good PRs. Thoughts? |
@carolynvs I think the area labels are mostly good, though I might omit "area: shared", as at least for now, i think we can treat that as implicit - if it's not one of the other areas, then it's shared. That and/or if it's in multiple areas, then apply the label for each of the areas it touches.
To the extent that these labels are supposed to reflect areas of responsibility for subsystem maintainers within the project, I'd say that the tests are implicitly included in the corresponding subsystem that they test. We could probably use a test label, but i think i's orthogonal to the "area" idea.
Definitely valuable, and yes, we could do this with labels. However, i've been using zenhub a bit with dep, though, and i'd say it's probably preferable that we express this kind of information using their pipelines. |
Yup, the goal was just to make it easier for various maintainers to keep up with issues in their area. I've removed |
Just checked zenhub and 😊 to be able to see more stuff in another dimension (zenhub-github 😬). |
Closing because it sounds like everyone is happy. 😇 |
I've done a quick pass through our issues and applied those labels. If I flagged something incorrectly, feel free to tweak! |
Once we have defined the various components of dep in #609, create labels for each area so that issues can be flagged with their impacted areas.
The text was updated successfully, but these errors were encountered: