You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Root project is "github.com/marvin-automator/marvin"
29 transitively valid internal packages
19 external packages imported from 12 projects
(0) ✓ select (root)
(1) ? attempt github.com/boltdb/bolt with 1 pkgs; at least 1 versions to try
(1) try github.com/boltdb/[email protected]
(1) ✓ select github.com/boltdb/[email protected] w/1 pkgs
(2) ? attempt github.com/gobuffalo/buffalo with 5 pkgs; 44 versions to try
(2) try github.com/gobuffalo/[email protected]
(2) ✓ select github.com/gobuffalo/[email protected] w/7 pkgs
(3) ? attempt github.com/dustin/go-humanize with 1 pkgs; at least 1 versions to try
(3) try github.com/dustin/go-humanize@master
(3) ✓ select github.com/dustin/go-humanize@master w/1 pkgs
(4) ? attempt github.com/gobuffalo/envy with 1 pkgs; at least 1 versions to try
(4) try github.com/gobuffalo/envy@master
(4) ✓ select github.com/gobuffalo/envy@master w/1 pkgs
(5) ? attempt github.com/gobuffalo/packr with 1 pkgs; at least 1 versions to try
(5) try github.com/gobuffalo/packr@master
(5) ✓ select github.com/gobuffalo/packr@master w/1 pkgs
(6) ? attempt github.com/gorilla/mux with 1 pkgs; at least 1 versions to try
(6) try github.com/gorilla/[email protected]
(6) ✓ select github.com/gorilla/[email protected] w/1 pkgs
(7) ? attempt github.com/gorilla/context with 1 pkgs; at least 1 versions to try
(7) try github.com/gorilla/[email protected]
(7) ✓ select github.com/gorilla/[email protected] w/1 pkgs
(8) ? attempt github.com/gobuffalo/tags with 1 pkgs; at least 1 versions to try
(8) try github.com/gobuffalo/tags@master
(8) ✓ select github.com/gobuffalo/tags@master w/1 pkgs
(9) ? attempt github.com/fatih/structs with 1 pkgs; at least 1 versions to try
(9) try github.com/fatih/[email protected]
(9) ✓ select github.com/fatih/[email protected] w/1 pkgs
(10) ? attempt github.com/gorilla/sessions with 1 pkgs; at least 1 versions to try
(10) try github.com/gorilla/[email protected]
(10) ✓ select github.com/gorilla/[email protected] w/1 pkgs
(11) ? attempt github.com/markbates/going with 2 pkgs; at least 1 versions to try
(11) try github.com/markbates/going@master
(11) ✓ select github.com/markbates/going@master w/2 pkgs
(12) ? attempt github.com/gobuffalo/plush with 1 pkgs; at least 1 versions to try
(12) try github.com/gobuffalo/plush@master
(12) ✓ select github.com/gobuffalo/plush@master w/5 pkgs
(13) ? revisit github.com/gobuffalo/tags to add 2 pkgs
(13) ✓ include 3 more pkgs from github.com/gobuffalo/tags@master
(13) ? attempt github.com/markbates/grift with 1 pkgs; at least 1 versions to try
(14) try github.com/markbates/grift@master
(14) ✓ select github.com/markbates/grift@master w/1 pkgs
(14) ? attempt github.com/gorilla/securecookie with 1 pkgs; at least 1 versions to try
(15) try github.com/gorilla/[email protected]
(15) ✓ select github.com/gorilla/[email protected] w/1 pkgs
(15) ? attempt github.com/markbates/refresh with 1 pkgs; at least 1 versions to try
(16) try github.com/markbates/[email protected]
(16) ✓ select github.com/markbates/[email protected] w/2 pkgs
(16) ? attempt github.com/fatih/color with 1 pkgs; at least 1 versions to try
(17) try github.com/fatih/[email protected]
(17) ✓ select github.com/fatih/[email protected] w/1 pkgs
(17) ? attempt github.com/fsnotify/fsnotify with 1 pkgs; at least 1 versions to try
(18) try github.com/fsnotify/[email protected]
(18) ✓ select github.com/fsnotify/[email protected] w/1 pkgs
(18) ? attempt github.com/mattn/go-colorable with 1 pkgs; at least 1 versions to try
(19) try github.com/mattn/[email protected]
(19) ✓ select github.com/mattn/[email protected] w/1 pkgs
(19) ? attempt github.com/markbates/validate with 2 pkgs; at least 1 versions to try
(20) try github.com/markbates/validate@master
(20) ✓ select github.com/markbates/validate@master w/2 pkgs
(20) ? revisit github.com/markbates/going to add 1 pkgs
(21) ✓ include 1 more pkgs from github.com/markbates/going@master
(20) ? attempt github.com/tonnerre/golang-pretty with 1 pkgs; at least 1 versions to try
(22) try github.com/tonnerre/golang-pretty@master
(22) ✓ select github.com/tonnerre/golang-pretty@master w/1 pkgs
(21) ? attempt github.com/gorilla/websocket with 1 pkgs; at least 1 versions to try
(23) try github.com/gorilla/[email protected]
(23) ✓ select github.com/gorilla/[email protected] w/1 pkgs
(22) ? attempt github.com/kr/text with 1 pkgs; at least 1 versions to try
(24) try github.com/kr/text@master
(24) ✓ select github.com/kr/text@master w/1 pkgs
(23) ? attempt github.com/markbates/inflect with 1 pkgs; at least 1 versions to try
(25) try github.com/markbates/inflect@master
(25) ✓ select github.com/markbates/inflect@master w/1 pkgs
(24) ? attempt github.com/mattn/go-isatty with 1 pkgs; at least 1 versions to try
(26) try github.com/mattn/[email protected]
(26) ✓ select github.com/mattn/[email protected] w/1 pkgs
(25) ? attempt github.com/sirupsen/logrus with 1 pkgs; at least 1 versions to try
(27) try github.com/sirupsen/[email protected]
(27) ✓ select github.com/sirupsen/[email protected] w/1 pkgs
(26) ? attempt golang.org/x/oauth2 with 2 pkgs; at least 1 versions to try
(28) try golang.org/x/oauth2@master
(28) ✓ select golang.org/x/oauth2@master w/3 pkgs
(27) ? attempt github.com/serenize/snaker with 1 pkgs; at least 1 versions to try
(29) try github.com/serenize/snaker@master
(29) ✓ select github.com/serenize/snaker@master w/1 pkgs
(28) ? attempt github.com/pkg/errors with 1 pkgs; at least 1 versions to try
(30) try github.com/pkg/[email protected]
(30) ✓ select github.com/pkg/[email protected] w/1 pkgs
(29) ? attempt github.com/mitchellh/go-homedir with 1 pkgs; at least 1 versions to try
(31) try github.com/mitchellh/go-homedir@master
(31) ✓ select github.com/mitchellh/go-homedir@master w/1 pkgs
(30) ? attempt golang.org/x/crypto with 1 pkgs; at least 1 versions to try
(32) try golang.org/x/crypto@master
(32) ✓ select golang.org/x/crypto@master w/2 pkgs
(31) ? attempt golang.org/x/sys with 1 pkgs; at least 1 versions to try
(33) try golang.org/x/sys@master
(33) ✓ select golang.org/x/sys@master w/1 pkgs
(32) ? attempt github.com/markbates/pop with 2 pkgs; at least 1 versions to try
(34) try github.com/markbates/[email protected]
(34) ✓ select github.com/markbates/[email protected] w/5 pkgs
(33) ? attempt github.com/go-sql-driver/mysql with 1 pkgs; at least 1 versions to try
(35) try github.com/go-sql-driver/[email protected]
(35) ✓ select github.com/go-sql-driver/[email protected] w/1 pkgs
(34) ? attempt github.com/mattn/anko with 2 pkgs; at least 1 versions to try
(36) try github.com/mattn/anko@master
(36) ✓ select github.com/mattn/anko@master w/27 pkgs
(35) ? attempt github.com/daviddengcn/go-colortext with 1 pkgs; at least 1 versions to try
(37) try github.com/daviddengcn/go-colortext@master
(37) ✓ select github.com/daviddengcn/go-colortext@master w/1 pkgs
(36) ? attempt github.com/stretchr/testify with 3 pkgs; at least 1 versions to try
(38) try github.com/stretchr/[email protected]
(38) ✓ select github.com/stretchr/[email protected] w/3 pkgs
(37) ? attempt github.com/davecgh/go-spew with 1 pkgs; at least 1 versions to try
(39) try github.com/davecgh/[email protected]
(39) ✓ select github.com/davecgh/[email protected] w/1 pkgs
(38) ? attempt github.com/lib/pq with 1 pkgs; at least 1 versions to try
(40) try github.com/lib/pq@master
(40) ✓ select github.com/lib/pq@master w/2 pkgs
(39) ? attempt github.com/jmoiron/sqlx with 1 pkgs; at least 1 versions to try
(41) try github.com/jmoiron/sqlx@master
(41) ✓ select github.com/jmoiron/sqlx@master w/2 pkgs
(40) ? attempt github.com/mattn/go-sqlite3 with 1 pkgs; at least 1 versions to try
(42) try github.com/mattn/[email protected]
(42) ✓ select github.com/mattn/[email protected] w/1 pkgs
(41) ? attempt github.com/pmezard/go-difflib with 1 pkgs; at least 1 versions to try
(43) try github.com/pmezard/[email protected]
(43) ✓ select github.com/pmezard/[email protected] w/1 pkgs
(42) ? attempt golang.org/x/net with 2 pkgs; at least 1 versions to try
(44) try golang.org/x/net@master
(44) ✓ select golang.org/x/net@master w/2 pkgs
(43) ? attempt google.golang.org/appengine with 1 pkgs; at least 1 versions to try
(45) try google.golang.org/[email protected]
(45) ✓ select google.golang.org/[email protected] w/7 pkgs
(44) ? attempt github.com/golang/protobuf with 1 pkgs; at least 1 versions to try
(46) try github.com/golang/protobuf@master
(46) ✓ select github.com/golang/protobuf@master w/1 pkgs
(45) ? attempt github.com/nicksnyder/go-i18n with 3 pkgs; at least 1 versions to try
(47) try github.com/nicksnyder/[email protected]
(47) ✓ select github.com/nicksnyder/[email protected] w/4 pkgs
(46) ? attempt github.com/monoculum/formam with 1 pkgs; at least 1 versions to try
(48) try github.com/monoculum/[email protected]
(48) ✓ select github.com/monoculum/[email protected] w/1 pkgs
(47) ? attempt github.com/satori/go.uuid with 1 pkgs; at least 1 versions to try
(49) try github.com/satori/[email protected]
(49) ✓ select github.com/satori/[email protected] w/1 pkgs
(48) ? attempt github.com/pelletier/go-toml with 1 pkgs; at least 1 versions to try
(50) try github.com/pelletier/[email protected]
(50) ✓ select github.com/pelletier/[email protected] w/1 pkgs
(49) ? attempt github.com/pelletier/go-buffruneio with 1 pkgs; at least 1 versions to try
(51) try github.com/pelletier/[email protected]
(51) ✓ select github.com/pelletier/[email protected] w/1 pkgs
(50) ? attempt github.com/shurcooL/github_flavored_markdown with 1 pkgs; at least 1 versions to try
(52) try github.com/shurcooL/github_flavored_markdown@master
(52) ✓ select github.com/shurcooL/github_flavored_markdown@master w/1 pkgs
(51) ? revisit golang.org/x/net to add 2 pkgs
(53) ✓ include 2 more pkgs from golang.org/x/net@master
(51) ? attempt github.com/russross/blackfriday with 1 pkgs; at least 1 versions to try
(54) try github.com/russross/[email protected]
(54) ✓ select github.com/russross/[email protected] w/1 pkgs
(52) ? attempt github.com/microcosm-cc/bluemonday with 1 pkgs; at least 1 versions to try
(55) try github.com/microcosm-cc/bluemonday@master
(55) ✓ select github.com/microcosm-cc/bluemonday@master w/1 pkgs
(53) ? attempt github.com/shurcooL/highlight_diff with 1 pkgs; at least 1 versions to try
(56) try github.com/shurcooL/highlight_diff@master
(56) ✓ select github.com/shurcooL/highlight_diff@master w/1 pkgs
(54) ? attempt github.com/sergi/go-diff with 1 pkgs; at least 1 versions to try
(57) try github.com/sergi/go-diff@master
(57) ✓ select github.com/sergi/go-diff@master w/1 pkgs
(55) ? attempt github.com/shurcooL/highlight_go with 1 pkgs; at least 1 versions to try
(58) try github.com/shurcooL/highlight_go@master
(58) ✓ select github.com/shurcooL/highlight_go@master w/1 pkgs
(56) ? attempt github.com/sourcegraph/syntaxhighlight with 1 pkgs; at least 1 versions to try
(59) try github.com/sourcegraph/syntaxhighlight@master
(59) ✓ select github.com/sourcegraph/syntaxhighlight@master w/1 pkgs
(57) ? attempt github.com/stretchr/objx with 1 pkgs; at least 1 versions to try
(60) try github.com/stretchr/objx@master
(60) ✓ select github.com/stretchr/objx@master w/1 pkgs
(58) ? attempt github.com/shurcooL/octiconssvg with 1 pkgs; at least 1 versions to try
(61) try github.com/shurcooL/octiconssvg@master
(61) ✓ select github.com/shurcooL/octiconssvg@master w/1 pkgs
(59) ? attempt github.com/shurcooL/go-goon with 1 pkgs; at least 1 versions to try
(62) try github.com/shurcooL/go-goon@master
(62) ✓ select github.com/shurcooL/go-goon@master w/1 pkgs
(60) ? attempt github.com/shurcooL/go with 1 pkgs; at least 1 versions to try
(63) try github.com/shurcooL/go@master
(63) ✓ select github.com/shurcooL/go@master w/4 pkgs
(61) ? attempt github.com/shurcooL/sanitized_anchor_name with 1 pkgs; at least 1 versions to try
(64) try github.com/shurcooL/sanitized_anchor_name@master
(64) ✓ select github.com/shurcooL/sanitized_anchor_name@master w/1 pkgs
(62) ? attempt github.com/sourcegraph/annotate with 1 pkgs; at least 1 versions to try
(65) try github.com/sourcegraph/annotate@master
(65) ✓ select github.com/sourcegraph/annotate@master w/1 pkgs
(63) ? attempt gopkg.in/yaml.v2 with 1 pkgs; at least 1 versions to try
(66) try gopkg.in/yaml.v2@v2
(66) ✓ select gopkg.in/yaml.v2@v2 w/1 pkgs
✓ found solution with 131 packages from 63 projects
Solver wall times by segment:
b-gmal: 24.612801586s
b-list-pkgs: 3.713958325s
b-source-exists: 2.009792031s
b-deduce-proj-root: 1.024212076s
satisfy: 16.207674ms
select-atom: 11.41175ms
select-root: 6.57298ms
new-atom: 2.820143ms
other: 290.29µs
b-list-versions: 89.594µs
b-pair-rev: 17.115µs
b-matches: 14.524µs
add-atom: 13.897µs
b-pair-version: 3.549µs
TOTAL: 31.398205534s
What did you expect to see?
I ran go test ./..., and expected the tests to pass.
What did you see instead?
vendor/github.com/kr/text/mc/mc.go:13:2: cannot find package "github.com/kr/pty" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/github.com/kr/pty (vendor tree)
/usr/local/go/src/github.com/kr/pty (from $GOROOT)
/Users/frederikcreemers/go/src/github.com/kr/pty (from $GOPATH)
vendor/github.com/mattn/go-sqlite3/tool/upgrade.go:16:2: cannot find package "github.com/PuerkitoBio/goquery" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/github.com/PuerkitoBio/goquery (vendor tree)
/usr/local/go/src/github.com/PuerkitoBio/goquery (from $GOROOT)
/Users/frederikcreemers/go/src/github.com/PuerkitoBio/goquery (from $GOPATH)
vendor/github.com/shurcooL/go/gopherjs_http/gopherjs_http.go:13:2: cannot find package "github.com/shurcooL/gopherjslib" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/github.com/shurcooL/gopherjslib (vendor tree)
/usr/local/go/src/github.com/shurcooL/gopherjslib (from $GOROOT)
/Users/frederikcreemers/go/src/github.com/shurcooL/gopherjslib (from $GOPATH)
vendor/github.com/shurcooL/go/gopherjs_http/jsutil/jsutil.go:8:2: cannot find package "github.com/gopherjs/gopherjs/js" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/github.com/gopherjs/gopherjs/js (vendor tree)
/usr/local/go/src/github.com/gopherjs/gopherjs/js (from $GOROOT)
/Users/frederikcreemers/go/src/github.com/gopherjs/gopherjs/js (from $GOPATH)
vendor/github.com/shurcooL/go/gopherjs_http/jsutil/jsutil.go:9:2: cannot find package "honnef.co/go/js/dom" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/honnef.co/go/js/dom (vendor tree)
/usr/local/go/src/honnef.co/go/js/dom (from $GOROOT)
/Users/frederikcreemers/go/src/honnef.co/go/js/dom (from $GOPATH)
vendor/github.com/shurcooL/go/pipeutil/dir.go:3:8: cannot find package "gopkg.in/pipe.v2" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/gopkg.in/pipe.v2 (vendor tree)
/usr/local/go/src/gopkg.in/pipe.v2 (from $GOROOT)
/Users/frederikcreemers/go/src/gopkg.in/pipe.v2 (from $GOPATH)
vendor/github.com/shurcooL/go/vfs/godocfs/godocfs/godocfs.go:8:2: cannot find package "github.com/shurcooL/httpfs/vfsutil" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/github.com/shurcooL/httpfs/vfsutil (vendor tree)
/usr/local/go/src/github.com/shurcooL/httpfs/vfsutil (from $GOROOT)
/Users/frederikcreemers/go/src/github.com/shurcooL/httpfs/vfsutil (from $GOPATH)
vendor/github.com/sirupsen/logrus/examples/hook/hook.go:5:2: cannot find package "gopkg.in/gemnasium/logrus-airbrake-hook.v2" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/gopkg.in/gemnasium/logrus-airbrake-hook.v2 (vendor tree)
/usr/local/go/src/gopkg.in/gemnasium/logrus-airbrake-hook.v2 (from $GOROOT)
/Users/frederikcreemers/go/src/gopkg.in/gemnasium/logrus-airbrake-hook.v2 (from $GOPATH)
vendor/golang.org/x/net/html/charset/charset.go:20:2: cannot find package "golang.org/x/text/encoding" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/golang.org/x/text/encoding (vendor tree)
/usr/local/go/src/golang.org/x/text/encoding (from $GOROOT)
/Users/frederikcreemers/go/src/golang.org/x/text/encoding (from $GOPATH)
vendor/golang.org/x/net/html/charset/charset.go:21:2: cannot find package "golang.org/x/text/encoding/charmap" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/golang.org/x/text/encoding/charmap (vendor tree)
/usr/local/go/src/golang.org/x/text/encoding/charmap (from $GOROOT)
/Users/frederikcreemers/go/src/golang.org/x/text/encoding/charmap (from $GOPATH)
vendor/golang.org/x/net/html/charset/charset.go:22:2: cannot find package "golang.org/x/text/encoding/htmlindex" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/golang.org/x/text/encoding/htmlindex (vendor tree)
/usr/local/go/src/golang.org/x/text/encoding/htmlindex (from $GOROOT)
/Users/frederikcreemers/go/src/golang.org/x/text/encoding/htmlindex (from $GOPATH)
vendor/golang.org/x/net/html/charset/charset.go:23:2: cannot find package "golang.org/x/text/transform" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/golang.org/x/text/transform (vendor tree)
/usr/local/go/src/golang.org/x/text/transform (from $GOROOT)
/Users/frederikcreemers/go/src/golang.org/x/text/transform (from $GOPATH)
vendor/golang.org/x/net/idna/idna.go:23:2: cannot find package "golang.org/x/text/secure/bidirule" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/golang.org/x/text/secure/bidirule (vendor tree)
/usr/local/go/src/golang.org/x/text/secure/bidirule (from $GOROOT)
/Users/frederikcreemers/go/src/golang.org/x/text/secure/bidirule (from $GOPATH)
vendor/golang.org/x/net/idna/idna.go:24:2: cannot find package "golang.org/x/text/unicode/norm" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/golang.org/x/text/unicode/norm (vendor tree)
/usr/local/go/src/golang.org/x/text/unicode/norm (from $GOROOT)
/Users/frederikcreemers/go/src/golang.org/x/text/unicode/norm (from $GOPATH)
vendor/golang.org/x/oauth2/google/default.go:16:2: cannot find package "cloud.google.com/go/compute/metadata" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/cloud.google.com/go/compute/metadata (vendor tree)
/usr/local/go/src/cloud.google.com/go/compute/metadata (from $GOROOT)
/Users/frederikcreemers/go/src/cloud.google.com/go/compute/metadata (from $GOPATH)
It seems like a whole bunch of transitive deps weren't installed. Installing them using go dep ensure <importpath> removes that from the list of missing packages, but that's no long term solution.
The text was updated successfully, but these errors were encountered:
go test ./... in Go 1.8 descends into your vendor/ directory. It appears dep ensure does not install all dependencies for your vendored dependencies.
Put another way dep ensure is installing all dependencies your application requires, by downloading the dependencies repository, but these repositories may contain other packages that have their own dependencies. It's those dependencies that aren't installed. But by running go test ./... in Go 1.8, those extra packages are being tested.
For example, look at the last error from your snippet above:
vendor/golang.org/x/oauth2/google/default.go:16:2: cannot find package "cloud.google.com/go/compute/metadata" in any of:
/Users/frederikcreemers/go/src/github.com/marvin-automator/marvin/vendor/cloud.google.com/go/compute/metadata (vendor tree)
/usr/local/go/src/cloud.google.com/go/compute/metadata (from $GOROOT)
/Users/frederikcreemers/go/src/cloud.google.com/go/compute/metadata (from $GOPATH)
The package golang.org/x/oauth2/google found in vendor directory can't find the package cloud.google.com/go/compute/metadata. But nothing you use imports it:
So this all appears to be working as intended to me, I'd advise using the command go test $(go list ./... | grep -v /vendor/) (for Linux at least) to test just your application and ignore everything in the vendor/ directory. Or wait until Go 1.9 which will behave like this by default.
If you do want go test ./... to work, I'm not sure what you need to do, and that behaviour will change in Go 1.9 anyway (golang/go#19090).
thanks for pitching in with the explanation there, @bradleyfalzon 😄
the main point here is that dep does not consider dependencies that are uniquely imported by your dependencies' tests. this is still awkward pre-Go 1.9 (where the problem is fixed, by that issue @bradleyfalzon linked), where ./... will still catch vendor/, as it means that go test ./... will try to run your dependencies' tests.
this is by design, though - it's not really on you to run your dependencies' tests.
What version of Go (
go version
) anddep
(git describe --tags
) are you using?Go version: go1.8.3 darwin/amd64
dep version: v0.1.0-313-g44a454b
What
dep
command did you run?In the root directory of this repository
output:
What did you expect to see?
I ran
go test ./...
, and expected the tests to pass.What did you see instead?
It seems like a whole bunch of transitive deps weren't installed. Installing them using
go dep ensure <importpath>
removes that from the list of missing packages, but that's no long term solution.The text was updated successfully, but these errors were encountered: