Skip to content
This repository has been archived by the owner on Jan 16, 2021. It is now read-only.

talksapp: accept markdown-based present files for talks.godoc.org #680

Open
sbinet opened this issue Apr 18, 2020 · 6 comments
Open

talksapp: accept markdown-based present files for talks.godoc.org #680

sbinet opened this issue Apr 18, 2020 · 6 comments
Labels

Comments

@sbinet
Copy link
Member

sbinet commented Apr 18, 2020

CL https://golang.org/cl/222846/ (and following) added support for markdown-based present files (as per golang/go#33955)

it would be great if the present instance running at talks.godoc.org was updated to accept them as well.

See:

@sbinet
Copy link
Member Author

sbinet commented May 9, 2020

@dmitshur was this the right place to file that issue?

@dmitshur
Copy link
Contributor

Sorry I missed this.

This is indeed the right issue tracker for tracking the work for talksapp.

@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2020

ping?

AFAIK, it's still using the old, non-markdown compliant, code...

@dmitshur
Copy link
Contributor

That is true, the work of updating talksapp hasn't been done. I'm not aware of someone planning to do this work soon.

Another factor to consider here is that it's not easy to deploy a new version of talksapp now because its deployment script hasn't been kept up to date, so resolving this issue will require also getting talksapp deployment fixed.

@sbinet
Copy link
Member Author

sbinet commented Aug 18, 2020

thanks circling back on this.
what would involve updating that deployment script? (ie: could this be done by a non-googler?)

@dmitshur
Copy link
Contributor

It should be possible, although it's harder because non-Googlers won't have access to the GCP project it's currently deployed to test everything works. But it can be deployed to another project for testing purposes.

The deployment app.yaml file is in talksapp directory. See commit 9bd4a32 for when it was done last time. This time, there are more changes to make because of changes between Go 1.9 and 1.11 runtimes, as documented at https://cloud.google.com/appengine/docs/standard/go111/go-differences.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants