Skip to content

Commit

Permalink
compress/flate: use built-in clear to simplify the code
Browse files Browse the repository at this point in the history
The new bootstrap toolchain allows us to use the built-in clear.

Updates #64751

Change-Id: Ic363e1059f34c46eaa4267c0b40a4ed8d5b3961b
GitHub-Last-Rev: 46ca735
GitHub-Pull-Request: #69253
Reviewed-on: https://go-review.googlesource.com/c/go/+/610516
Reviewed-by: Dmitri Shuralyov <[email protected]>
LUCI-TryBot-Result: Go LUCI <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
Auto-Submit: Ian Lance Taylor <[email protected]>
  • Loading branch information
apocelipes authored and gopherbot committed Sep 6, 2024
1 parent 123594d commit 12dcbed
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 21 deletions.
8 changes: 2 additions & 6 deletions src/compress/flate/deflate.go
Original file line number Diff line number Diff line change
Expand Up @@ -612,12 +612,8 @@ func (d *compressor) reset(w io.Writer) {
d.bestSpeed.reset()
default:
d.chainHead = -1
for i := range d.hashHead {
d.hashHead[i] = 0
}
for i := range d.hashPrev {
d.hashPrev[i] = 0
}
clear(d.hashHead[:])
clear(d.hashPrev[:])
d.hashOffset = 1
d.index, d.windowEnd = 0, 0
d.blockStart, d.byteAvailable = 0, false
Expand Down
4 changes: 1 addition & 3 deletions src/compress/flate/deflatefast.go
Original file line number Diff line number Diff line change
Expand Up @@ -286,9 +286,7 @@ func (e *deflateFast) reset() {
func (e *deflateFast) shiftOffsets() {
if len(e.prev) == 0 {
// We have no history; just clear the table.
for i := range e.table[:] {
e.table[i] = tableEntry{}
}
clear(e.table[:])
e.cur = maxMatchOffset + 1
return
}
Expand Down
16 changes: 4 additions & 12 deletions src/compress/flate/huffman_bit_writer.go
Original file line number Diff line number Diff line change
Expand Up @@ -198,9 +198,7 @@ func (w *huffmanBitWriter) writeBytes(bytes []byte) {
// numOffsets The number of offsets in offsetEncoding
// litenc, offenc The literal and offset encoder to use
func (w *huffmanBitWriter) generateCodegen(numLiterals int, numOffsets int, litEnc, offEnc *huffmanEncoder) {
for i := range w.codegenFreq {
w.codegenFreq[i] = 0
}
clear(w.codegenFreq[:])
// Note that we are using codegen both as a temporary variable for holding
// a copy of the frequencies, and as the place where we put the result.
// This is fine because the output is always shorter than the input used
Expand Down Expand Up @@ -530,12 +528,8 @@ func (w *huffmanBitWriter) writeBlockDynamic(tokens []token, eof bool, input []b
// and offsetEncoding.
// The number of literal and offset tokens is returned.
func (w *huffmanBitWriter) indexTokens(tokens []token) (numLiterals, numOffsets int) {
for i := range w.literalFreq {
w.literalFreq[i] = 0
}
for i := range w.offsetFreq {
w.offsetFreq[i] = 0
}
clear(w.literalFreq)
clear(w.offsetFreq)

for _, t := range tokens {
if t < matchType {
Expand Down Expand Up @@ -621,9 +615,7 @@ func (w *huffmanBitWriter) writeBlockHuff(eof bool, input []byte) {
}

// Clear histogram
for i := range w.literalFreq {
w.literalFreq[i] = 0
}
clear(w.literalFreq)

// Add everything as literals
histogram(input, w.literalFreq)
Expand Down

0 comments on commit 12dcbed

Please sign in to comment.