all: Go 1.9.5 release status

[andybons]

Go 1.9.5 release status

Issues with fixes

• cmd/compile: bad small array comparisons on amd64 since go1.9 #23719 cmd/compile: bad small array comparisons on amd64 since go1.9
  • CL 103115 per andybons; [release-branch.go1.9] cmd/compile: use unsigned loads for multi-element comparisons
• cmd/go: options missing from cgo whitelists #23749 cmd/go: options missing from cgo whitelists
  • CL 103156 per andybons; [release-branch.go1.9] cmd/go: add more C compiler/linker options to whitelist
• go/compile: corrupted function return value #23812 go/compile: corrupted function return value
  • CL 93716 per andybons; cmd/compile: fix constant folding of right shifts
  • CL 94028 per andybons; cmd/compile: fix constant folding of right shifts on s390x
• cmd/go: 1.9.4 can't build x/sys/unix with GOOS=solaris #23939 cmd/go: 1.9.4 can't build x/sys/unix with GOOS=solaris
  • CL 103135 per andybons; [release-branch.go1.9] cmd/go: add options to security whitelist
  • CL 103155 per andybons; [release-branch.go1.9] cmd/go: permit pkg-config flags in any argument position
• Document Go 1.9.5 #24565 Document Go 1.9.5
  • CL 103216 per andybons; doc: document Go 1.9.5
  • CL 103159 per andybons; doc: update release notes for Go 1.9.5
  • CL 103163 per andybons; doc: update 1.9.5 release notes to include net/http/pprof
• cmd/go: arbitrary command execution via VCS path [1.9.5] #24567 cmd/go: arbitrary command execution via VCS path [1.9.5]
  • CL 94603 per andybons; cmd/go: restrict meta imports to valid schemes
• cmd/go: add more options to security whitelist [1.9.5] #24579 cmd/go: add more options to security whitelist [1.9.5]
  • CL 103156 per andybons; [release-branch.go1.9] cmd/go: add more C compiler/linker options to whitelist
• net/http/pprof: harden handler responses [1.9.5] #24586 net/http/pprof: harden handler responses [1.9.5]
  • CL 102318 per andybons; net/http/pprof: harden handler responses

Changes on release branch

• CL 102775 (cherry-pick of CL 93716) (for go/compile: corrupted function return value #23812)
  • cmd/compile: fix constant folding of right shifts
• CL 102777 (cherry-pick of CL 94028) (for go/compile: corrupted function return value #23812)
  • cmd/compile: fix constant folding of right shifts on s390x
• CL 102776 (cherry-pick of CL 94603) (for cmd/go: arbitrary command execution via VCS path [1.9.5] #24567)
  • cmd/go: restrict meta imports to valid schemes
• CL 103164 (cherry-pick of CL 102318) (for net/http/pprof: harden handler responses [1.9.5] #24586)
  • net/http/pprof: harden handler responses
• CL 103220 (cherry-pick of CL 103216) (for Document Go 1.9.5 #24565)
  • doc: document Go 1.9.5
• CL 103161 (cherry-pick of CL 103159) (for Document Go 1.9.5 #24565)
  • doc: update release notes for Go 1.9.5
• CL 103165 (cherry-pick of CL 103163) (for Document Go 1.9.5 #24565)
  • doc: update 1.9.5 release notes to include net/http/pprof
• CL 103115 (new for release-branch) (for cmd/compile: bad small array comparisons on amd64 since go1.9 #23719)
  • [release-branch.go1.9] cmd/compile: use unsigned loads for multi-element comparisons
• CL 103135 (new for release-branch) (for cmd/go: 1.9.4 can't build x/sys/unix with GOOS=solaris #23939)
  • [release-branch.go1.9] cmd/go: add options to security whitelist
• CL 103155 (new for release-branch) (for cmd/go: 1.9.4 can't build x/sys/unix with GOOS=solaris #23939)
  • [release-branch.go1.9] cmd/go: permit pkg-config flags in any argument position
• CL 103156 (new for release-branch) (for cmd/go: options missing from cgo whitelists #23749 cmd/go: add more options to security whitelist [1.9.5] #24579)
  • [release-branch.go1.9] cmd/go: add more C compiler/linker options to whitelist
• CL 103167 (cherry-pick of CL 0) (for)
  • go1.9.5

Latest build: go1.9.5

git fetch origin refs/changes/67/103167/1 &&
git checkout 902108f080af39ea02099549f07d646d32de4a84

src (tar.gz)
linux-386 (tar.gz)
linux-armv6l (tar.gz)
linux-amd64 (tar.gz)
linux-arm64 (tar.gz)
freebsd-386 (tar.gz)
freebsd-amd64 (tar.gz)
windows-386 (zip) (msi)
windows-amd64 (zip) (msi)
darwin-amd64 (tar.gz) (pkg)
linux-s390x (tar.gz)
linux-ppc64le (tar.gz)

Log

2018/03/29 00:17:14 starting
2018/03/29 00:17:14 working in /usr/local/google/home/andybons/go-releasebot-work/go1.9.5
2018/03/29 00:17:14 $ git fetch origin master
2018/03/29 00:17:15 $ git fetch origin release-branch.go1.9
2018/03/29 00:17:16 $ git clone --reference /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gitmirror -b release-branch.go1.9 https://go.googlesource.com/go /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gitwork
2018/03/29 00:17:19 $ git codereview change relwork
2018/03/29 00:17:20 $ git config gc.auto 0
2018/03/29 00:17:20 $ git rev-parse go1.9.5
2018/03/29 00:17:28 # CL 93716
2018/03/29 00:17:28 $ git cherry-pick 755b36aa532f6b23081bf5eaf83449c1a6dd8114
2018/03/29 00:17:29 $ git commit --amend --no-edit
2018/03/29 00:17:30 reusing existing refs/changes/75/102775/1 for CL 93716
2018/03/29 00:17:30 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:30 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:30 # CL 94028
2018/03/29 00:17:30 $ git cherry-pick 1566bf90253097dfec83f621a48e761ded4d2144
2018/03/29 00:17:31 $ git commit --amend --no-edit
2018/03/29 00:17:32 reusing existing refs/changes/77/102777/1 for CL 94028
2018/03/29 00:17:32 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:32 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:33 # CL 94603
2018/03/29 00:17:33 $ git cherry-pick c941e27e70c3e06e1011d2dd71d72a7a06a9bcbc
2018/03/29 00:17:33 $ git commit --amend --no-edit
2018/03/29 00:17:35 reusing existing refs/changes/76/102776/2 for CL 94603
2018/03/29 00:17:35 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:35 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:36 # CL 102318
2018/03/29 00:17:36 $ git cherry-pick baa46bcf5b532a8f6d6684af8c0e500ce4cd41d2
2018/03/29 00:17:36 $ git commit --amend --no-edit
2018/03/29 00:17:37 reusing existing refs/changes/64/103164/1 for CL 102318
2018/03/29 00:17:37 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:38 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:38 # CL 103216
2018/03/29 00:17:38 $ git cherry-pick 2f14fc9c682f6e6a6489a4e4757edd4011ba08e9
2018/03/29 00:17:38 $ git commit --amend --no-edit
2018/03/29 00:17:40 reusing existing refs/changes/20/103220/2 for CL 103216
2018/03/29 00:17:40 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:40 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:41 # CL 103159
2018/03/29 00:17:41 $ git cherry-pick 03d1dd8c2afb42bc59185275abfedc4225496740
2018/03/29 00:17:41 $ git commit --amend --no-edit
2018/03/29 00:17:43 reusing existing refs/changes/61/103161/2 for CL 103159
2018/03/29 00:17:43 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:43 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:44 # CL 103163
2018/03/29 00:17:44 $ git cherry-pick cc936d12bde1fe850b9f3928868105d76fbd53d8
2018/03/29 00:17:44 $ git commit --amend --no-edit
2018/03/29 00:17:46 reusing existing refs/changes/65/103165/1 for CL 103163
2018/03/29 00:17:46 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:46 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:47 # CL 103115
2018/03/29 00:17:47 $ git cherry-pick 4e30249d4e794f6339fb79337963c9e7e8acc80c
2018/03/29 00:17:47 $ git commit --amend --no-edit
2018/03/29 00:17:48 reusing existing refs/changes/15/103115/10 for CL 103115
2018/03/29 00:17:48 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:49 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:49 # CL 103135
2018/03/29 00:17:49 $ git cherry-pick 6f0eb28def88879ee3d47755cb59bb95588ffd32
2018/03/29 00:17:49 $ git commit --amend --no-edit
2018/03/29 00:17:51 reusing existing refs/changes/35/103135/11 for CL 103135
2018/03/29 00:17:51 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:51 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:51 # CL 103155
2018/03/29 00:17:51 $ git cherry-pick 8045cd6637118fb8f25bb79819b68dab1e01543a
2018/03/29 00:17:52 $ git commit --amend --no-edit
2018/03/29 00:17:54 reusing existing refs/changes/55/103155/11 for CL 103155
2018/03/29 00:17:54 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:54 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:54 # CL 103156
2018/03/29 00:17:54 $ git cherry-pick d5f7c28dc65f9696f5cd1ab04ff2101eec76624e
2018/03/29 00:17:54 $ git commit --amend --no-edit
2018/03/29 00:17:56 reusing existing refs/changes/56/103156/11 for CL 103156
2018/03/29 00:17:56 $ git reset --hard FETCH_HEAD
2018/03/29 00:17:56 found trybot OK on Gerrit; skipping make.bash
2018/03/29 00:17:58 $ git show 902108f080af39ea02099549f07d646d32de4a84:VERSION
2018/03/29 00:17:58 reusing refs/changes/67/103167/1 for VERSION
2018/03/29 00:17:58 $ git reset --hard 902108f080af39ea02099549f07d646d32de4a84
2018/03/29 00:17:59 $ go get golang.org/x/build/cmd/release
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target linux-386 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target freebsd-386 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target src -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target windows-amd64 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target darwin-amd64 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target linux-armv6l -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target windows-386 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target linux-arm64 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target freebsd-amd64 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target linux-s390x -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target linux-ppc64le -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:18:23 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target linux-amd64 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:20:53 release linux-386: %!s(<nil>)
2018/03/29 00:18:23 linux-386: Start.
2018/03/29 00:18:23 linux-386: Creating buildlet.
2018/03/29 00:20:53 linux-386: Error: 500 Internal Server Error: buildlet pod left the Running phase and entered phase "Failed"
2018/03/29 00:21:53 $ /usr/local/google/home/andybons/go-releasebot-work/go1.9.5/gopath/bin/release -target linux-386 -user release -version go1.9.5 -rev 902108f080af39ea02099549f07d646d32de4a84 -tools release-branch.go1.9 -net release-branch.go1.9
2018/03/29 00:22:57 release linux-386: %!s(<nil>)
2018/03/29 00:21:53 linux-386: Start.
2018/03/29 00:21:53 linux-386: Creating buildlet.
2018/03/29 00:22:57 linux-386: Error: 500 Internal Server Error: buildlet pod left the Running phase and entered phase "Failed"

— golang.org/x/build/cmd/releasebot, Mar 29 04:22:57 UTC

[FiloSottile]

Looks like #23867, #23750 and #22724 are tagged 1.10.1 but also affect 1.9 and don't have a 1.9.5 clone.

[FiloSottile]

@andybons We will also need a 1.9.5 version of #24583.

[andybons]

Doing this manually (without releasebot).