-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: maybe show legacy tags in pseudoversions #25898
Comments
Particularly useful if you're using branches during active development. |
I'm not going to do this for Go 1.11. I think it's important not to clutter the pseudo-version with non-essential information, so that there is always a single canonical form in all the things that print versions. For Go 1.12 maybe we can find a way to put it in a comment instead. |
We could also retain the original |
If it'll live in the version string not in a comment, note that git tags, branches etc can contain slashes. |
If you do
where tag is not a proper semver tag for foo, then vgo looks up tag, resolves the commit, finds the date on the commit, and records instead of tag a pseudo-version like
I wonder if we should preserve the tag, so that the recorded version would be:
This would work for branch names and legacy semver tags too, of course, so that we could have:
These would just show a little bit more information when you list your dependencies in projects not using tagged releases (or at least vgo-compatible tagged releases in the case of the legacy v17).
The text was updated successfully, but these errors were encountered: