-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/go: get must report implied upgrades/downgrades #25917
Comments
@bcmills I don't think you can expect:
to work because Back to the subject of the golang-nuts thread however, I do see a number of issues when I try to Details
Incidentally, /cc @kardianos |
Can confirm this:
Suprisingly, all of the errors refer to existing revisions. |
|
@rsc I'm a little confused. The command as you spoke it in the comment above doesn't "work" for me (on the tip of master branch of vgo at time of writing golang/vgo@8a71b2b):
Additionally, I can't figure out how to get https://github.com/pwaller/vgo-use-dockerclient to use docker
So I can't tell that this issue is fixed as it is stated by the reporter? This still seems to be blocking me from using any docker import post v1.x as far as I can tell, assuming that I have not misunderstood what I need to do to make that work. This latter error also looks strange, and I can't easily tell what has gone wrong. Why is it looking for a v17 directory inside the repository? /cc @bcmills |
It looks like
|
None of the That is, |
Does that mean it is not possible to use v17 without docker introducing a To answer my own question, presumably the way to do it is to depend on a |
Yes, you can use a pseudo-version.
|
Still not working at head, but the symptom has changed to
|
The problem here is that v17.05.0-ce is NOT a semantic version at all: the leading 0 in 05 makes it malformed. But because v1.13.1 was tagged earlier, it looks like docker depends on something that in turn depends back on docker and gets v1.13.1. At the very least we need to diagnose this problem better in go get. I changed the title because go get pkg@version does work in general. |
In that case we should probably reopen #26380 (which is just |
Change https://golang.org/cl/124800 mentions this issue: |
This is a followup to a golang-nuts thread.
I can import an arbitrary version of the module
github.com/docker/docker
(which lacks ago.mod
file at all tagged versions in its repo) by specifying the version in thego.mod
file. However, at least as of vgo0a6cdd7
, I can't obtain the same version usingvgo get
on one of the packages it contains.The text was updated successfully, but these errors were encountered: