-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
crypto/tls: expose names for CurveID and SignatureScheme #35499
Comments
/cc @FiloSottile |
Change https://golang.org/cl/208226 mentions this issue: |
Adding to proposal minutes, seems headed for likely accept. |
@katiehockman, @FiloSottile, are you in favor of this proposal? |
@rsc I see no issues with doing this, and the rationale seems reasonable. The CL for this was pretty straight-forward too. |
Same, this looks good to me. |
Based on the discussion above, this seems like a likely accept. |
No change in consensus, so accepting. |
The constants for CurveID and SignatureScheme don't have any String() methods.
This makes printing these values (for example in log files) awkward as there is just a number.
To workaround this one can make a map to lookup from the constants to some friendly name (the constant name). As the constants already have custom types it would be best to implement the stringer interface for them in the standard library.
The idea is similiar to #30325
I created a first draft in #35297
The text was updated successfully, but these errors were encountered: