Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: "expected declaration, found 'package'" after cutting and pasting a file's contents #38424

Closed
stamblerre opened this issue Apr 13, 2020 · 2 comments
Closed

x/tools/gopls: "expected declaration, found 'package'" after cutting and pasting a file's contents #38424

stamblerre opened this issue Apr 13, 2020 · 2 comments
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
gopls/v0.4.4

Comments

@stamblerre
Copy link
Contributor

stamblerre commented Apr 13, 2020 •
edited
Loading

I've noticed that the go list empty file error message will sometimes reappear in this case. This needs both a fix and a regression test.
@gopherbot gopherbot added this to the Unreleased milestone Apr 13, 2020
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Apr 13, 2020
@stamblerre stamblerre modified the milestones: Unreleased, gopls/v0.5.0 Apr 13, 2020
@stamblerre stamblerre mentioned this issue May 5, 2020
Closed
@stamblerre stamblerre changed the title x/tools/gopls: regression test for deleting a file's contents and returning it x/tools/gopls: "expected declaration, found 'package'" after cutting and pasting a file's contents May 5, 2020
@stamblerre stamblerre mentioned this issue Jun 2, 2020
Closed
@segevfiner
Copy link
Contributor

I'm seeing this issue. Looks like something like starting with an empty file or removing it's content, then typing the package statement, waiting a bit, and continuing on to write some other stuff in the file, like a func main. Is this the gopls in memory representation of the file getting messed up or something?

@gopherbot
Copy link
Contributor

Change https://golang.org/cl/243577 mentions this issue: internal/lsp: handle deletion of file content

@stamblerre stamblerre modified the milestones: gopls/v0.5.0, gopls/v0.4.4 Jul 21, 2020
@golang golang locked and limited conversation to collaborators Jul 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
FrozenDueToAge gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
gopls/v0.4.4
Development

No branches or pull requests
3 participants
@stamblerre @gopherbot @segevfiner