Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/build/cmd/gopherbot: ignore Go versions in backport comments after the first period? #41012

Closed
bcmills opened this issue Aug 24, 2020 · 1 comment
Closed

x/build/cmd/gopherbot: ignore Go versions in backport comments after the first period? #41012

bcmills opened this issue Aug 24, 2020 · 1 comment
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Unreleased

Comments

@bcmills
Copy link
Contributor

bcmills commented Aug 24, 2020

@gopherbot opened two backport issues in response to #40999 (comment). However, I had only intended to open one: the second sentence was intended to explain why not to open a second backport issue.

Perhaps we could improve the GopherBot parsing heuristics to only backport to versions mentioned in the first sentence?

(CC @golang/osp-team)
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 24, 2020
@gopherbot gopherbot added this to the Unreleased milestone Aug 24, 2020
@bcmills bcmills added FeatureRequest NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. and removed Builders x/build issues (builders, bots, dashboards) labels Aug 24, 2020
@gopherbot gopherbot added the Builders x/build issues (builders, bots, dashboards) label Aug 24, 2020
@dmitshur
Copy link
Contributor

Thanks for report. I understand this issue is the same as #27489.

@dmitshur dmitshur mentioned this issue Aug 24, 2020
Open
@golang golang locked and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Builders x/build issues (builders, bots, dashboards) FeatureRequest FrozenDueToAge NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
None yet
Milestone
Unreleased
Development

No branches or pull requests
3 participants
@dmitshur @bcmills @gopherbot