log/syslog: TestWrite failures with empty Info

[bcmills]

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

--- FAIL: TestWrite (1.83s)
    syslog_test.go:335: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (0 unexpected EOF)
FAIL
FAIL	log/syslog	2.690s

greplogs -l -e 'FAIL: TestWrite.*(?:\n\s+.*)*s\.Info\(\) = '\''""'\' --since=2022-01-01
2022-09-07T16:00:20-7033275/linux-amd64-wsl
2022-06-17T21:35:36-d42a488/netbsd-arm64-bsiegert

[bcmills]

It appears that both of the run helpers for this test are setting arbitrary deadlines and swallowing errors:
https://cs.opensource.google/go/go/+/master:src/log/syslog/syslog_test.go;l=30-41;drc=f78efc0178d51c02beff8a8203910dc0a9c6e953
https://cs.opensource.google/go/go/+/master:src/log/syslog/syslog_test.go;l=70-78;drc=f78efc0178d51c02beff8a8203910dc0a9c6e953

Probably a good start would be to eliminate the arbitrary deadlines and at least emit the errors to the test log.

[gopherbot]

Found new matching dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

2022-09-07 16:00 linux-amd64-wsl go@7033275e log/syslog.TestWrite (log)

--- FAIL: TestWrite (1.83s)
    syslog_test.go:335: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (0 unexpected EOF)

— watchflakes

[gopherbot]

Change https://go.dev/cl/451855 mentions this issue: log/syslog: add log when deadline exceeded

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

2023-01-20 21:55 freebsd-arm-paulzhol go@27b6ace2 log/syslog.TestWrite (log)

--- FAIL: TestWrite (8.87s)
    syslog_test.go:335: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (0 unexpected EOF)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

2023-04-11 22:42 darwin-amd64-10_15 go@bc5b1948 log/syslog.TestWrite (log)

--- FAIL: TestWrite (1.26s)
    syslog_test.go:335: s.Info() = '"<11>2023-04-11T18:54:01-04:00 Gophers-iMac-Pro-2.local syslog_test[6558]: write test\n"', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (3 %!s(<nil>))
    syslog_test.go:335: s.Info() = '"<11>2023-04-11T18:54:01-04:00 Gophers-iMac-Pro-2.local syslog_test[6558]: write test 2\n"', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (3 %!s(<nil>))

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

2023-04-27 21:12 solaris-amd64-oraclerel go@635839a1 log/syslog.TestWrite (log)

--- FAIL: TestWrite (1.49s)
    syslog_test.go:338: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test\n"' (0 unexpected EOF)

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

2023-08-17 21:10 darwin-amd64-10_15 go@b4636682 log/syslog.TestWrite (log)

--- FAIL: TestWrite (1.26s)
    syslog_test.go:335: s.Info() = '"<11>2023-08-18T00:55:10-04:00 Gophers-iMac-Pro-2.local syslog_test[7283]: write test 2\n"', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (3 %!s(<nil>))

— watchflakes

[gopherbot]

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "log/syslog" && test == "TestWrite"

2023-10-11 20:23 dragonfly-amd64-622 go@eff7aef4 log/syslog.TestWrite (log)

--- FAIL: TestWrite (1.35s)
    syslog_test.go:338: s.Info() = '""', didn't match '"<11>%s %s syslog_test[%d]: write test 2\n"' (0 unexpected EOF)

— watchflakes