x/vuln: tests consistently failing on Android builders due to missing "compile" tool starting 2022-11-02 #57147

bcmills · 2022-12-07T20:43:11Z

--- FAIL: TestInits (0.20s)
    callstacks_test.go:191: err: exit status 2: stderr: go: no such tool "compile"
        
FAIL
exitcode=1
FAIL	golang.org/x/vuln/internal/govulncheck	46.719s

ok  	golang.org/x/vuln/internal/semver	46.828s

ok  	golang.org/x/vuln/internal/web	47.031s

ok  	golang.org/x/vuln/osv	46.925s
--- FAIL: TestSlicing (0.04s)
    slicing_test.go:96: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestImports (0.95s)
    source_test.go:117: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestRequires (0.07s)
    source_test.go:259: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestCalls (0.06s)
    source_test.go:496: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestFiltering (0.06s)
    source_test.go:595: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestAllSymbolsVulnerable (0.05s)
    source_test.go:686: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestNoSyntheticNodes (0.04s)
    source_test.go:752: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestRecursion (0.07s)
    source_test.go:833: err: exit status 2: stderr: go: no such tool "compile"
        
--- FAIL: TestConvert (0.09s)
    vulncheck_test.go:414: err: exit status 2: stderr: go: no such tool "compile"
        
FAIL
exitcode=1
FAIL	golang.org/x/vuln/vulncheck	48.377s

greplogs -l -e '\Aandroid.*(\n.*)*no such tool "compile"(.*\n)*FAIL\s+golang\.org/x/vuln' --since=2022-07-01 --details

(236 matching logs)

(attn @golang/vulndb)

The text was updated successfully, but these errors were encountered:

bcmills · 2022-12-07T20:44:13Z

Either the tests should be fixed, or the android builders should be configured not to run for x/vuln — either way, we shouldn't be wasting resources on test runs that are doomed to fail.

zpavlinovic · 2022-12-07T23:06:26Z

The issue is not triggered by changes to x/vuln. It seems to come and go. I believe it is likely related to GOROOT only on Android since we use packagestest to build unit-test code. I could add t.Skip for each test, but I guess it is better to not run android builders on x/vuln.

bcmills · 2022-12-08T01:03:28Z

If it's using packagestest, then #47257 may be what triggered the tests to start failing. I wonder if it's feasible for packagestest to add that skip itself?

bcmills · 2022-12-08T01:05:02Z

Or, maybe it would suffice to update the x/tools dependency past CL 451597?

bcmills · 2022-12-08T16:21:07Z

Looks like that will do it. (Mailed CL 456122, which is passing on an android-amd64-emu SlowBot.)

bcmills added Testing An issue that has been verified to require only test changes, not just a test failure. OS-Android NeedsFix The path to resolution is known, but the work has not been done. vulncheck or vulndb Issues for the x/vuln or x/vulndb repo x/vuln labels Dec 7, 2022

gopherbot modified the milestones: Unreleased, vuln/unplanned Dec 7, 2022

zpavlinovic self-assigned this Dec 7, 2022

bcmills self-assigned this Dec 8, 2022

bcmills mentioned this issue Dec 8, 2022

x/build: update x/ dependencies in untagged x/ repos when applying tags #56530

Closed

bcmills closed this as completed Dec 8, 2022

golang locked and limited conversation to collaborators Dec 8, 2023

gopherbot added the FrozenDueToAge label Dec 8, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

x/vuln: tests consistently failing on Android builders due to missing "compile" tool starting 2022-11-02 #57147

x/vuln: tests consistently failing on Android builders due to missing "compile" tool starting 2022-11-02 #57147

bcmills commented Dec 7, 2022

bcmills commented Dec 7, 2022

zpavlinovic commented Dec 7, 2022 •

edited

Loading

bcmills commented Dec 8, 2022

bcmills commented Dec 8, 2022 •

edited

Loading

bcmills commented Dec 8, 2022

x/vuln: tests consistently failing on Android builders due to missing "compile" tool starting 2022-11-02 #57147

x/vuln: tests consistently failing on Android builders due to missing "compile" tool starting 2022-11-02 #57147

Comments

bcmills commented Dec 7, 2022

bcmills commented Dec 7, 2022

zpavlinovic commented Dec 7, 2022 • edited Loading

bcmills commented Dec 8, 2022

bcmills commented Dec 8, 2022 • edited Loading

bcmills commented Dec 8, 2022

zpavlinovic commented Dec 7, 2022 •

edited

Loading

bcmills commented Dec 8, 2022 •

edited

Loading