Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x/tools/gopls: don't offer code lenses/actions that assume go build when using GOPACKAGESDRIVER #67922

Open
adonovan opened this issue Jun 10, 2024 · 3 comments
Open

x/tools/gopls: don't offer code lenses/actions that assume go build when using GOPACKAGESDRIVER #67922

adonovan opened this issue Jun 10, 2024 · 3 comments
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Milestone
Backlog

Comments

@adonovan
Copy link
Member

Gopls should not offer any commands that assume the underlying build command is go when using a go packages driver (e.g. bazel). See #67615 (comment) for the various commands that need tweaking.
@gopherbot gopherbot added Tools This label describes issues relating to any tools in the x/tools repository. gopls Issues related to the Go language server, gopls. labels Jun 10, 2024
@gopherbot gopherbot added this to the Unreleased milestone Jun 10, 2024
@adonovan adonovan changed the title x/tools/gopls: don't offer code lenses/actions that assume go build x/tools/gopls: don't offer code lenses/actions that assume go build when using GOPACKAGESDRIVER Jun 10, 2024
@adonovan adonovan modified the milestones: Unreleased, Backlog Jun 10, 2024
@adonovan adonovan mentioned this issue Jun 10, 2024
Closed
@gabyhelp
Copy link

Similar Issues

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@adonovan
Copy link
Member Author

Opinion: the ML-based "similar issues" are not entirely dissimilar: in particular, the first seems like an umbrella issue that covers this one.

@findleyr
Copy link
Contributor

Indeed, they're not as dissimilar as I first thought.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
gopls Issues related to the Go language server, gopls. Tools This label describes issues relating to any tools in the x/tools repository.
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
4 participants
@adonovan @gopherbot @findleyr @gabyhelp