Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/vet,x/tools/go/analysis/passes/printf: broken with GODEBUG=gotypesalias=1 [1.23 backport] #68813

Closed
gopherbot opened this issue Aug 9, 2024 · 2 comments
Milestone

Comments

@gopherbot
Copy link
Contributor

@findleyr requested issue #68796 to be considered for backport to the next 1.23 minor release.

@gopherbot please backport this issue to 1.23. It is a regression that may affect vet if #68797 is also backported.

@gopherbot gopherbot added the CherryPickCandidate Used during the release process for point releases label Aug 9, 2024
@gopherbot gopherbot added this to the Go1.23.1 milestone Aug 9, 2024
@findleyr
Copy link
Contributor

findleyr commented Aug 9, 2024

As I said in #68796 (comment), I'm not sure we need to backport this fix, unless we also decide to also backport a fix for #68797.

@findleyr
Copy link
Contributor

findleyr commented Aug 9, 2024

Since we're not planning to backport the fix to #68797, I think we no longer need to backport this fix to the printf analyzer in Go 1.23.1. As long as GODEBUG=gotypesalias=0, which is the case in vet as a result of #68797, printf analyses should work as intended. Therefore, the simplest path forward is to do nothing.

@findleyr findleyr closed this as not planned Won't fix, can't repro, duplicate, stale Aug 9, 2024
@dmitshur dmitshur removed the CherryPickCandidate Used during the release process for point releases label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants