Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any type json marshaling. #170

Closed
AmandaCameron opened this issue Apr 15, 2016 · 6 comments
Closed

Any type json marshaling. #170

AmandaCameron opened this issue Apr 15, 2016 · 6 comments
Assignees

Comments

@AmandaCameron
Copy link

It'd be nice if the Any type could be marshaled properly by jsonpb, as currently it ends up marshaling as a couple of strings, one of which being the base64-encoded value of the type.

I recognise this might not be an easy-to-do thing (I had forked to try and get it going, but couldn't find an obvious place for it. ) however it is still wanted, so at the very least this can be a tracking bug or similar.

@dsymonds
Copy link
Contributor

It's just something we haven't gotten to yet. The text format supports Any messages; jsonpb just needs to be updated.

@AmandaCameron
Copy link
Author

If you can give me some hints as to where I should be hooking in, I'd be glad to try and tackle this problem, as it's something of great interest to me.

ATM, I'm mildly confused as to wether I should be poking at marshalValue or marshalObject, as neither seem particularly well-suited for types that are actually objects, instead of primitives, at least in the WKT corner.

Or am I to assume that this isn't exactly trivial in the current code layout, and that's why it's not been gotten to yet.

@dsymonds dsymonds self-assigned this Apr 19, 2016
@dsymonds
Copy link
Contributor

I'll see if I can get it done today.

@dsymonds
Copy link
Contributor

I should have marshaling done later today. It was a bit trickier than the other well-known types.

Unmarshaling is going to be harder again; that'll be a TODO for now. Is that going to be something important for you?

@AmandaCameron
Copy link
Author

Marshaling only will be fine for now. However has there been a tracking bug for me to follow for possible updates in the future?

@dsymonds
Copy link
Contributor

There isn't, but feel free to open one.

@golang golang locked and limited conversation to collaborators Jun 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants