From 18267e2065c00d6124770dda53e49b1426be38e2 Mon Sep 17 00:00:00 2001 From: Fernandez Ludovic Date: Tue, 13 Aug 2024 19:10:14 +0200 Subject: [PATCH] chore: update to go1.23 GA --- .github/workflows/documentation.yml | 2 +- .github/workflows/post-release.yml | 2 +- .github/workflows/pr-documentation.yml | 2 +- .github/workflows/pr-extra.yml | 2 +- .github/workflows/pr.yml | 6 ++++-- .github/workflows/tag.yml | 2 +- 6 files changed, 9 insertions(+), 7 deletions(-) diff --git a/.github/workflows/documentation.yml b/.github/workflows/documentation.yml index 64185b9f5e96..8fa63376fc89 100644 --- a/.github/workflows/documentation.yml +++ b/.github/workflows/documentation.yml @@ -15,7 +15,7 @@ jobs: # ex: # - 1.18beta1 -> 1.18.0-beta.1 # - 1.18rc1 -> 1.18.0-rc.1 - GO_VERSION: '1.23.0-rc.2' + GO_VERSION: '1.23' NODE_VERSION: '20.x' CGO_ENABLED: 0 steps: diff --git a/.github/workflows/post-release.yml b/.github/workflows/post-release.yml index d2e18fa4d584..0403d8f461c4 100644 --- a/.github/workflows/post-release.yml +++ b/.github/workflows/post-release.yml @@ -15,7 +15,7 @@ jobs: # ex: # - 1.18beta1 -> 1.18.0-beta.1 # - 1.18rc1 -> 1.18.0-rc.1 - GO_VERSION: '1.23.0-rc.2' + GO_VERSION: '1.23' steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5 diff --git a/.github/workflows/pr-documentation.yml b/.github/workflows/pr-documentation.yml index 6345cc713652..60a76668daea 100644 --- a/.github/workflows/pr-documentation.yml +++ b/.github/workflows/pr-documentation.yml @@ -13,7 +13,7 @@ jobs: # ex: # - 1.18beta1 -> 1.18.0-beta.1 # - 1.18rc1 -> 1.18.0-rc.1 - GO_VERSION: '1.23.0-rc.2' + GO_VERSION: '1.23' NODE_VERSION: '20.x' CGO_ENABLED: 0 diff --git a/.github/workflows/pr-extra.yml b/.github/workflows/pr-extra.yml index 215aaca62310..83b6ca24c064 100644 --- a/.github/workflows/pr-extra.yml +++ b/.github/workflows/pr-extra.yml @@ -17,7 +17,7 @@ jobs: # ex: # - 1.18beta1 -> 1.18.0-beta.1 # - 1.18rc1 -> 1.18.0-rc.1 - go-version: '1.23.0-rc.2' + go-version: '1.23' - name: Run go list run: go list -json -m all > go.list - name: Nancy diff --git a/.github/workflows/pr.yml b/.github/workflows/pr.yml index 906e403578d5..e92dc6e7b333 100644 --- a/.github/workflows/pr.yml +++ b/.github/workflows/pr.yml @@ -10,7 +10,7 @@ env: # ex: # - 1.18beta1 -> 1.18.0-beta.1 # - 1.18rc1 -> 1.18.0-rc.1 - GO_VERSION: '1.23.0-rc.2' + GO_VERSION: '1.23' jobs: # Check if there is any dirty change for go mod tidy @@ -39,6 +39,8 @@ jobs: # ex: # - 1.18beta1 -> 1.18.0-beta.1 # - 1.18rc1 -> 1.18.0-rc.1 + # TODO(ldez) must be changed after the first release of golangci-lint with go1.23 + # go-version: ${{ env.GO_VERSION }} go-version: '1.22' - name: lint uses: golangci/golangci-lint-action@v6.1.0 @@ -74,7 +76,7 @@ jobs: matrix: golang: - '1.22' - - '1.23.0-rc.1' + - '1.23' steps: - uses: actions/checkout@v4 - uses: actions/setup-go@v5 diff --git a/.github/workflows/tag.yml b/.github/workflows/tag.yml index e9b17c533170..8f855fe2c71c 100644 --- a/.github/workflows/tag.yml +++ b/.github/workflows/tag.yml @@ -12,7 +12,7 @@ jobs: # ex: # - 1.18beta1 -> 1.18.0-beta.1 # - 1.18rc1 -> 1.18.0-rc.1 - GO_VERSION: '1.23.0-rc.1' + GO_VERSION: '1.23' CHOCOLATEY_VERSION: 2.2.0 steps: - uses: actions/checkout@v4