Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade does not alter the return value of volume() #575

Closed
Dadibom opened this issue Jul 20, 2016 · 5 comments
Closed

Fade does not alter the return value of volume() #575

Dadibom opened this issue Jul 20, 2016 · 5 comments

Comments

@Dadibom
Copy link

Dadibom commented Jul 20, 2016

I'm creating a howl, playing it and using fade(0,desiredvolume,time) to fade the track in. If desiredvolume is 0 (anything over will make volume() work correctly), the track will be quiet as expected but calling volume() will return 1. This was not the case in 1.x, only in the 2.0 branch.

@Dadibom
Copy link
Author

Dadibom commented Jul 20, 2016

It does not matter if i manually call volume(0) before the fade call, fade(0,0,time) will still make volume() return 1

@Dadibom
Copy link
Author

Dadibom commented Jul 20, 2016

Quick fix: throw this into the very beginning of the fade method
if(e==0&&o==0){this.volume(0);return}

@ghost
Copy link

ghost commented Jul 20, 2016

This might explain some weird behaviour I've been getting, I ended up manually tweening the volume I think

@ghost
Copy link

ghost commented Jul 20, 2016

Just to make sure @Dadibom the master branch of howler is now the v2, so if the master branch works then it's not v1 -> v2 problem

@Dadibom
Copy link
Author

Dadibom commented Jul 20, 2016

No, I went from the latest 1.x.x to 2.0.0-rc2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant