Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The settlement algorithm does not treat acceptances covered by an existing payment that was too low as overdue #1007

Closed
cameel opened this issue Dec 7, 2018 · 1 comment · Fixed by #1015
Closed

The settlement algorithm does not treat acceptances covered by an existing payment that was too low as overdue #1007

cameel opened this issue Dec 7, 2018 · 1 comment · Fixed by #1015
Assignees
@Jakub89
Labels
bug _high_priority this has a high priority and should be handled ASAP payment use case 'force payment' use case
Milestone
0.11.0

Comments

@cameel
Copy link
Contributor

cameel commented Dec 7, 2018 •
edited
Loading

As explained in the #996 blueprint, an acceptance should be treated as overdue if one of the following is true:

  • It's been more than PDT since payment_ts.
  • The requestor has already made a regular payment with closure_time >= payment_ts.

Currently Concent allows only the first condition which leaves the provider unable to submit acceptances that must really be submitted now because they won't be taken into account in the next settlement.
@cameel cameel added bug not in pivotal Not yet added as a task in any story in Pivotal payment use case 'force payment' use case labels Dec 7, 2018
@PaweuB
Copy link

PaweuB commented Dec 7, 2018

Pivotal:
https://www.pivotaltracker.com/story/show/162505420

@PaweuB PaweuB added _high_priority this has a high priority and should be handled ASAP and removed not in pivotal Not yet added as a task in any story in Pivotal labels Dec 7, 2018
@Jakub89 Jakub89 mentioned this issue Dec 12, 2018
Merged
@kbeker kbeker added this to the next milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jakub89 Jakub89

Labels
bug _high_priority this has a high priority and should be handled ASAP payment use case 'force payment' use case
Projects
None yet
Milestone
0.11.0
4 participants
@cameel @Jakub89 @kbeker @PaweuB