Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong closure_time in settlement payments #1016

Closed
cameel opened this issue Dec 12, 2018 · 1 comment
Closed

Wrong closure_time in settlement payments #1016

cameel opened this issue Dec 12, 2018 · 1 comment
Assignees
Labels
bankster Bankster and related features bug _high_priority this has a high priority and should be handled ASAP payment use case 'force payment' use case
Milestone

Comments

@cameel
Copy link
Contributor

cameel commented Dec 12, 2018

Currently Bankster sets closure_time in a settlement payment to the current time:

cut_off_time = get_current_utc_timestamp()
        transaction_hash = service.make_force_payment_to_provider(  # pylint: disable=no-value-for-parameter
            requestor_eth_address=requestor_ethereum_address,
            provider_eth_address=provider_ethereum_address,
            value=requestor_payable_amount,
            payment_ts=cut_off_time,
)

This is wrong. As illustrated in the #996 blueprint, the closure_time of a forced payment must be equal to payment_ts to the youngest acceptance submitted by the provider.

This is similar to the bug discovered in #1015 by @Jakub89 but this time its in the payment itself.

@cameel cameel added bug not in pivotal Not yet added as a task in any story in Pivotal payment use case 'force payment' use case bankster Bankster and related features labels Dec 12, 2018
@PaweuB
Copy link

PaweuB commented Dec 13, 2018

@PaweuB PaweuB added _high_priority this has a high priority and should be handled ASAP and removed not in pivotal Not yet added as a task in any story in Pivotal labels Dec 13, 2018
@rwrzesien rwrzesien self-assigned this Dec 13, 2018
@kbeker kbeker added this to the next milestone Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bankster Bankster and related features bug _high_priority this has a high priority and should be handled ASAP payment use case 'force payment' use case
Projects
None yet
Development

No branches or pull requests

4 participants